[GTK] accessibility/svg-remote-element.html is failing

https://bugs.webkit.org/show_bug.cgi?id=101185

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-30
Reviewed by Chris Fleizach.

Tools:

Implemented missing methods by mimicing existing functionality in
AccessibilityObject::clickPoint() using available ATK API.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::clickPointX): Implemented.
(AccessibilityUIElement::clickPointY): Implemented.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::clickPointX): Implemented.
(WTR::AccessibilityUIElement::clickPointY): Implemented.

LayoutTests:

Provided new test expectations since resulting discrepancies are believed to be
platform related.

* platform/gtk-wk2/TestExpectations: The test is no longer failing.
* platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
* platform/gtk/TestExpectations: The test is no longer failing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent fc9b2bc4
2013-10-30 Robert Plociennik <r.plociennik@samsung.com>
[GTK] accessibility/svg-remote-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101185
Reviewed by Chris Fleizach.
Provided new test expectations since resulting discrepancies are believed to be
platform related.
* platform/gtk-wk2/TestExpectations: The test is no longer failing.
* platform/gtk/accessibility/svg-remote-element-expected.txt: Added.
* platform/gtk/TestExpectations: The test is no longer failing.
2013-10-30 Krzysztof Czech <k.czech@samsung.com>
[EFL] Remove efl/accessibility/image-map1-expected.txt after r158104
......
......@@ -342,7 +342,6 @@ webkit.org/b/106338 accessibility/aria-hidden-updates-alldescendants.html [ Fail
webkit.org/b/106340 accessibility/img-fallsback-to-title.html [ Failure ]
webkit.org/b/116970 accessibility/multiselect-list-reports-active-option.html [ Failure ]
webkit.org/b/116971 accessibility/poorly-formed-aria-table.html [ Failure ]
webkit.org/b/106346 accessibility/svg-remote-element.html [ Failure ]
# svg/ failures
webkit.org/b/42457 svg/custom/embedded-svg-allowed-in-dashboard.xml [ Failure ]
......
......@@ -882,7 +882,6 @@ webkit.org/b/98363 accessibility/canvas-fallback-content-2.html [ Failure ]
webkit.org/b/98371 accessibility/loading-iframe-updates-axtree.html [ Failure ]
webkit.org/b/98372 accessibility/onclick-handlers.html [ Failure ]
webkit.org/b/98375 accessibility/secure-textfield-title-ui.html [ Failure ]
webkit.org/b/101185 accessibility/svg-remote-element.html [ Failure ]
webkit.org/b/98377 accessibility/textarea-insertion-point-line-number.html [ Failure ]
webkit.org/b/98378 accessibility/textarea-line-for-index.html [ Failure ]
webkit.org/b/98379 accessibility/textarea-selected-text-range.html [ Failure ]
......
This test ensures that accessibility elements can be created out of what a remote SVG image defines.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
container location: (7, 7)
Face role: AXRole: AXButton
Face label: AXDescription: face
FaceX: 0
FaceY: 0
Eye role: AXRole: AXButton
Eye label: AXDescription: left-eye
EyeX: 103
EyeY: 148
Nose role: AXRole: AXButton
Nose label: AXDescription: nose
NoseX: 193
NoseY: 206
Mouth role: AXRole: AXButton
Mouth label: AXDescription: smile
MouthX: 116
MouthY: 276
PASS successfullyParsed is true
TEST COMPLETE
2013-10-30 Robert Plociennik <r.plociennik@samsung.com>
[GTK] accessibility/svg-remote-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101185
Reviewed by Chris Fleizach.
Implemented missing methods by mimicing existing functionality in
AccessibilityObject::clickPoint() using available ATK API.
* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::clickPointX): Implemented.
(AccessibilityUIElement::clickPointY): Implemented.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::clickPointX): Implemented.
(WTR::AccessibilityUIElement::clickPointY): Implemented.
2013-10-30 Tamas Gergely <gertom@inf.u-szeged.hu>
Removed Windows platform configurations from WebKitTestRunner.
......
......@@ -743,14 +743,30 @@ double AccessibilityUIElement::height()
double AccessibilityUIElement::clickPointX()
{
// Note: This is not something we have in ATK.
return 0;
if (!ATK_IS_COMPONENT(m_element))
return 0;
int x, y;
atk_component_get_position(ATK_COMPONENT(m_element), &x, &y, ATK_XY_WINDOW);
int width, height;
atk_component_get_size(ATK_COMPONENT(m_element), &width, &height);
return x + width / 2.0;
}
double AccessibilityUIElement::clickPointY()
{
// Note: This is not something we have in ATK.
return 0;
if (!ATK_IS_COMPONENT(m_element))
return 0;
int x, y;
atk_component_get_position(ATK_COMPONENT(m_element), &x, &y, ATK_XY_WINDOW);
int width, height;
atk_component_get_size(ATK_COMPONENT(m_element), &width, &height);
return y + height / 2.0;
}
JSStringRef AccessibilityUIElement::orientation() const
......
......@@ -868,14 +868,30 @@ double AccessibilityUIElement::height()
double AccessibilityUIElement::clickPointX()
{
// FIXME: implement
return 0;
if (!ATK_IS_COMPONENT(m_element.get()))
return 0;
int x, y;
atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, &y, ATK_XY_WINDOW);
int width, height;
atk_component_get_size(ATK_COMPONENT(m_element.get()), &width, &height);
return x + width / 2.0;
}
double AccessibilityUIElement::clickPointY()
{
// FIXME: implement
return 0;
if (!ATK_IS_COMPONENT(m_element.get()))
return 0;
int x, y;
atk_component_get_position(ATK_COMPONENT(m_element.get()), &x, &y, ATK_XY_WINDOW);
int width, height;
atk_component_get_size(ATK_COMPONENT(m_element.get()), &width, &height);
return y + height / 2.0;
}
double AccessibilityUIElement::intValue() const
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment