Commit af43bf0e authored by aroben's avatar aroben

Reviewed by Tim H.

        This change fixes a couple of problems with the window-properties
        test. window-properties' output changes depending on the presence or
        non-presence of session history (see
        http://bugs.webkit.org/show_bug.cgi?id=10965 for details). For this
        reason, the test must always be run as part of a run of ALL layout
        tests. The test results checked in were generated from an individual
        run of this test, so the buildbots were always failing since they run
        all the tests at once.

        This change regenerates the results for the test using a full run of
        layout tests. The test now also prints out object class names, and
        will print an error message when the test is run by itself.

        * fast/js/window-properties-expected.txt:
        * fast/js/window-properties.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent cd947c9d
2006-10-02 Adam Roben <aroben@apple.com>
Reviewed by Tim H.
This change fixes a couple of problems with the window-properties
test. window-properties' output changes depending on the presence or
non-presence of session history (see
http://bugs.webkit.org/show_bug.cgi?id=10965 for details). For this
reason, the test must always be run as part of a run of ALL layout
tests. The test results checked in were generated from an individual
run of this test, so the buildbots were always failing since they run
all the tests at once.
This change regenerates the results for the test using a full run of
layout tests. The test now also prints out object class names, and
will print an error message when the test is run by itself.
* fast/js/window-properties-expected.txt:
* fast/js/window-properties.html:
2006-10-02 Adele Peterson <adele@apple.com>
Reviewed by Adam.
......@@ -52,7 +52,15 @@ function printProperties(object, parentString) {
if (shouldSkipProperty(fullPropertyName, propertyValue))
continue;
var type = (propertyValue === null ? 'null' : typeof(propertyValue));
log(fullPropertyName + " : " + type);
var classname = '';
if (type == 'object') {
try {
classname = ' (' + Object.prototype.toString.call(propertyValue).replace(/^\[object (.*)\]$/, '$1') + ')';
} catch(e) {
log(fullPropertyName + " : ERROR accessing class name, exception thrown: " + e);
}
}
log(fullPropertyName + " : " + type + classname);
var previousPropertyName = '';
if (propertyValue && type == 'object') {
if (shouldSkipChildren(fullPropertyName, propertyValue))
......@@ -69,6 +77,12 @@ log('window : ' + typeof(window));
havePrintedChildren(window, 'window');
printProperties(window, 'window');
if (!window.opener) {
// FIXME: This test should be able to specify that it depends on the (non)existence of session history
// http://bugs.webkit.org/show_bug.cgi?id=10965
log('This test must be run as part of ALL LayoutTests to run correctly');
}
</script>
</body>
</html>
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment