Commit ae8c3acf authored by rwlbuis@webkit.org's avatar rwlbuis@webkit.org

feImage fails if referenced node contains radialGradient declaration

https://bugs.webkit.org/show_bug.cgi?id=118735

Reviewed by Darin Adler.

Source/WebCore:

Only call parent's updateRelativeLengthsInformation for graphics elements.

Tests: svg/custom/feImage-pserver-with-percentage-expected.svg
       svg/custom/feImage-pserver-with-percentage.svg

* svg/SVGElement.cpp:
(WebCore::SVGElement::updateRelativeLengthsInformation):

LayoutTests:

Add testcase from bug with small adjustments.

* svg/custom/feImage-pserver-with-percentage-expected.svg: Added.
* svg/custom/feImage-pserver-with-percentage.svg: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 66de1c18
2013-08-27 Rob Buis <rwlbuis@webkit.org>
feImage fails if referenced node contains radialGradient declaration
https://bugs.webkit.org/show_bug.cgi?id=118735
Reviewed by Darin Adler.
Add testcase from bug with small adjustments.
* svg/custom/feImage-pserver-with-percentage-expected.svg: Added.
* svg/custom/feImage-pserver-with-percentage.svg: Added.
2013-08-27 Chris Fleizach <cfleizach@apple.com>
<https://webkit.org/b/120117> AX: <noscript> contents are exposed as static text
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="100%" height="100%">
<defs>
<filter filterUnits="userSpaceOnUse" primitiveUnits="userSpaceOnUse" id="flt" x="0" y="0" width="50" height="100">
<feImage xlink:href="#img" />
</filter>
</defs>
<rect filter="url(#flt)" width="50" height="100"/>
<g transform="translate(50 0)">
<g id="img">
<rect width="50" height="100" fill="green"/>
</g>
</g>
</svg>
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="100%" height="100%">
<g>
<filter filterUnits="userSpaceOnUse" primitiveUnits="userSpaceOnUse" id="flt" x="0" y="0" width="50" height="100">
<feImage xlink:href="#img" />
</filter>
<rect filter="url(#flt)" width="50" height="100"/>
<g transform="translate(50 0)">
<g id="img">
<radialGradient />
<rect width="50" height="100" fill="green"/>
</g>
</g>
</g>
</svg>
2013-08-27 Rob Buis <rwlbuis@webkit.org>
feImage fails if referenced node contains radialGradient declaration
https://bugs.webkit.org/show_bug.cgi?id=118735
Reviewed by Darin Adler.
Only call parent's updateRelativeLengthsInformation for graphics elements.
Tests: svg/custom/feImage-pserver-with-percentage-expected.svg
svg/custom/feImage-pserver-with-percentage.svg
* svg/SVGElement.cpp:
(WebCore::SVGElement::updateRelativeLengthsInformation):
2013-08-27 Darin Adler <darin@apple.com>
No need for generalPasteboard (aside from "global selection mode")
......@@ -1121,6 +1121,9 @@ void SVGElement::updateRelativeLengthsInformation(bool hasRelativeLengths, SVGEl
m_elementsWithRelativeLengths.remove(element);
}
if (!element->isSVGGraphicsElement())
return;
// Find first styled parent node, and notify it that we've changed our relative length state.
ContainerNode* node = parentNode();
while (node) {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment