Commit ae736128 authored by jparent@chromium.org's avatar jparent@chromium.org
Browse files

Dashboard cleanup: remove dashboard time logging.

https://bugs.webkit.org/show_bug.cgi?id=111608

Reviewed by Dirk Pranke.

Remove logTime.  It was never accurate, and the dev tools
have better ways to measure this if anyone cares to look
into dashboard perf.

* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(processTestRunsForBuilder):
(appendHTML):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent a64e3188
2013-03-06 Julie Parent <jparent@chromium.org>
Dashboard cleanup: remove dashboard time logging.
https://bugs.webkit.org/show_bug.cgi?id=111608
Reviewed by Dirk Pranke.
Remove logTime. It was never accurate, and the dev tools
have better ways to measure this if anyone cares to look
into dashboard perf.
* TestResultServer/static-dashboards/dashboard_base.js:
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(processTestRunsForBuilder):
(appendHTML):
2013-03-06 Tony Chang <tony@chromium.org>
 
[chromium] making DumpRenderTree_resources a separate bundle breaks xcode
......@@ -32,7 +32,6 @@
//
// The calling page is expected to implement the following "abstract"
// functions/objects:
var g_pageLoadStartTime = Date.now();
var g_resourceLoader;
// Generates the contents of the dashboard. The page should override this with
......@@ -549,11 +548,6 @@ function joinParameters(stateObject)
return state.join('&');
}
function logTime(msg, startTime)
{
console.log(msg + ': ' + (Date.now() - startTime));
}
function hidePopup()
{
var popup = $('popup');
......@@ -845,9 +839,6 @@ document.addEventListener('mousedown', function(e) {
}, false);
window.addEventListener('load', function() {
// This doesn't seem totally accurate as there is a race between
// onload firing and the last script tag being executed.
logTime('Time to load JS', g_pageLoadStartTime);
g_resourceLoader = new loader.Loader();
g_resourceLoader.load();
}, false);
......@@ -942,8 +942,7 @@ function processTestRunsForBuilder(builderName)
}
processExpectations();
var start = Date.now();
var buildInfo = platformAndBuildType(builderName);
var platform = buildInfo.platform;
var buildType = buildInfo.buildType;
......@@ -996,7 +995,6 @@ function processTestRunsForBuilder(builderName)
}
g_perBuilderFailures[builderName] = failures;
logTime('processTestRunsForBuilder: ' + builderName, start);
}
function processMissingAndExtraExpectations(resultsForTest)
......@@ -1469,13 +1467,11 @@ function htmlForTestTable(rowsHTML, opt_excludeHeaders)
function appendHTML(html)
{
var startTime = Date.now();
// InnerHTML to a div that's not in the document. This is
// ~300ms faster in Safari 4 and Chrome 4 on mac.
var div = document.createElement('div');
div.innerHTML = html;
document.body.appendChild(div);
logTime('Time to innerHTML', startTime);
postHeightChangedMessage();
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment