Commit ae539ad0 authored by cfleizach@apple.com's avatar cfleizach@apple.com
Browse files

Regression in tests due to https://bugs.webkit.org/show_bug.cgi?id=113339

https://bugs.webkit.org/show_bug.cgi?id=113361

Source/WebCore: 

Fix the red bots. No review.

Ensure only pop-up buttons get the AXRequired attribute instead of all buttons.        

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests: 

Remove skipped tests.

* platform/mac/TestExpectations:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 30430b7a
2013-03-27 Chris Fleizach <cfleizach@apple.com>
Regression in tests due to https://bugs.webkit.org/show_bug.cgi?id=113339
https://bugs.webkit.org/show_bug.cgi?id=113361
Remove skipped tests.
* platform/mac/TestExpectations:
2013-03-27 Zoltan Arvai <zarvai@inf.u-szeged.hu>
 
[Qt] Unreviewed gardening. Cleanup after r146756 and r146786.
......@@ -1477,6 +1477,3 @@ webkit.org/b/113227 transitions/cross-fade-border-image.html [ Pass Failure ]
webkit.org/b/113227 transitions/default-timing-function.html [ Pass Failure ]
webkit.org/b/113227 transitions/svg-text-shadow-transition.html [ Pass Failure ]
# Failed due to http://trac.webkit.org/changeset/146949
webkit.org/b/113361 accessibility/table-with-aria-role.html [ Failure ]
webkit.org/b/113361 platform/mac/accessibility/button-shouldnot-have-axvalue.html [ Failure ]
\ No newline at end of file
2013-03-27 Chris Fleizach <cfleizach@apple.com>
Regression in tests due to https://bugs.webkit.org/show_bug.cgi?id=113339
https://bugs.webkit.org/show_bug.cgi?id=113361
Fix the red bots. No review.
Ensure only pop-up buttons get the AXRequired attribute instead of all buttons.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
2013-03-27 Vsevolod Vlasov <vsevik@chromium.org>
 
Web Inspector: Breakpoint manager should restore breakpoints when uiSourceCode is added.
......@@ -994,9 +994,11 @@ static id textMarkerRangeFromVisiblePositions(AXObjectCache *cache, VisiblePosit
// All objects should expose the ARIA busy attribute (ARIA 1.1 with ISSUE-538).
[additional addObject:NSAccessibilityARIABusyAttribute];
// Popup buttons on the Mac expose the value attribute.
if (m_object->isPopUpButton())
// Popup buttons on the Mac expose the required and value attributes.
if (m_object->isPopUpButton()) {
[additional addObject:NSAccessibilityValueAttribute];
[additional addObject:NSAccessibilityRequiredAttribute];
}
if (m_object->ariaHasPopup())
[additional addObject:NSAccessibilityHasPopupAttribute];
......@@ -1220,7 +1222,6 @@ static id textMarkerRangeFromVisiblePositions(AXObjectCache *cache, VisiblePosit
[tempArray removeObject:NSAccessibilityValueAttribute];
[tempArray addObject:NSAccessibilityTitleUIElementAttribute];
[tempArray addObject:NSAccessibilityAccessKeyAttribute];
[tempArray addObject:NSAccessibilityRequiredAttribute];
buttonAttrs = [[NSArray alloc] initWithArray:tempArray];
[tempArray release];
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment