Commit ae17af2f authored by mario@webkit.org's avatar mario@webkit.org
Browse files

2011-04-08 Mario Sanchez Prada <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
        https://bugs.webkit.org/show_bug.cgi?id=58039

        Implemented missing functions in GTK's DRT.

        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (modifyAccessibilityValue): Helper function to increment or decrement
        the current value for an object through the AccessibilityObject's API.
        (DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function,
        to be used from GTK's DRT.
        (DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.
2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
        https://bugs.webkit.org/show_bug.cgi?id=58039

        Implement missing functions in GTK's DRT.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::increment): Implemented.
        (AccessibilityUIElement::decrement): Implemented.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 82731cc9
2011-04-08 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=58039
Implemented missing functions in GTK's DRT.
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(modifyAccessibilityValue): Helper function to increment or decrement
the current value for an object through the AccessibilityObject's API.
(DumpRenderTreeSupportGtk::incrementAccessibilityValue): New function,
to be used from GTK's DRT.
(DumpRenderTreeSupportGtk::decrementAccessibilityValue): Ditto.
2011-04-06 Gustavo Noronha Silva <gns@gnome.org>
 
Reviewed by Martin Robinson.
......
......@@ -679,6 +679,31 @@ void DumpRenderTreeSupportGtk::setMinimumTimerInterval(WebKitWebView* webView, d
core(webView)->settings()->setMinDOMTimerInterval(interval);
}
static void modifyAccessibilityValue(AtkObject* axObject, bool increment)
{
if (!axObject || !WEBKIT_IS_ACCESSIBLE(axObject))
return;
AccessibilityObject* coreObject = webkit_accessible_get_accessibility_object(WEBKIT_ACCESSIBLE(axObject));
if (!coreObject)
return;
if (increment)
coreObject->increment();
else
coreObject->decrement();
}
void DumpRenderTreeSupportGtk::incrementAccessibilityValue(AtkObject* axObject)
{
modifyAccessibilityValue(axObject, true);
}
void DumpRenderTreeSupportGtk::decrementAccessibilityValue(AtkObject* axObject)
{
modifyAccessibilityValue(axObject, false);
}
void DumpRenderTreeSupportGtk::setAutofilled(JSContextRef context, JSValueRef nodeObject, bool autofilled)
{
JSC::ExecState* exec = toJS(context);
......
......@@ -100,6 +100,10 @@ public:
static double defaultMinimumTimerInterval(); // Not really tied to WebView
static void setMinimumTimerInterval(WebKitWebView*, double);
// Accessibility
static void incrementAccessibilityValue(AtkObject*);
static void decrementAccessibilityValue(AtkObject*);
// GC
static void gcCollectJavascriptObjects();
static void gcCollectJavascriptObjectsOnAlternateThread(bool waitUntilDone);
......
2011-04-08 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=58039
Implement missing functions in GTK's DRT.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::increment): Implemented.
(AccessibilityUIElement::decrement): Implemented.
2011-04-08 Dominic Cooney <dominicc@google.com>
Reviewed by Kent Tamura.
......
......@@ -26,15 +26,14 @@
#include "config.h"
#include "AccessibilityUIElement.h"
#include "GOwnPtr.h"
#include "GRefPtr.h"
#include "WebCoreSupport/DumpRenderTreeSupportGtk.h"
#include <JavaScriptCore/JSStringRef.h>
#include <wtf/Assertions.h>
#include <atk/atk.h>
#include <gtk/gtk.h>
#include <wtf/Assertions.h>
AccessibilityUIElement::AccessibilityUIElement(PlatformUIElement element)
: m_element(element)
......@@ -572,12 +571,20 @@ bool AccessibilityUIElement::isAttributeSupported(JSStringRef attribute)
void AccessibilityUIElement::increment()
{
// FIXME: implement
if (!m_element)
return;
ASSERT(ATK_IS_OBJECT(m_element));
DumpRenderTreeSupportGtk::incrementAccessibilityValue(ATK_OBJECT(m_element));
}
void AccessibilityUIElement::decrement()
{
// FIXME: implement
if (!m_element)
return;
ASSERT(ATK_IS_OBJECT(m_element));
DumpRenderTreeSupportGtk::decrementAccessibilityValue(ATK_OBJECT(m_element));
}
void AccessibilityUIElement::press()
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment