Commit ad36374a authored by ojan@chromium.org's avatar ojan@chromium.org

2010-04-15 Ojan Vafai <ojan@chromium.org>

        Reviewed by Adam Barth.

        Include codereview issue number in patch description
        https://bugs.webkit.org/show_bug.cgi?id=37677

        This lets us know which rietveld issue this patch is tied to.

        Also, make it so that --fancy-review overrides --no-review.

        * Scripts/webkitpy/tool/steps/postcodereview.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 54b86c01
2010-04-15 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
Include codereview issue number in patch description
https://bugs.webkit.org/show_bug.cgi?id=37677
This lets us know which rietveld issue this patch is tied to.
Also, make it so that --fancy-review overrides --no-review.
* Scripts/webkitpy/tool/steps/postcodereview.py:
* Scripts/webkitpy/tool/steps/postdiff.py:
2010-04-15 Adam Roben <aroben@apple.com>
Make --exit-after-n-failures work when all tests are timing out or crashing
......@@ -43,8 +43,6 @@ class PostCodeReview(AbstractStep):
def run(self, state):
if not self._options.fancy_review:
return
if not self._options.review:
return
# FIXME: This will always be None because we don't retrieve the issue
# number from the ChangeLog yet.
codereview_issue = state.get("codereview_issue")
......
......@@ -48,8 +48,10 @@ class PostDiff(AbstractStep):
description = self._options.description or "Patch"
comment_text = None
codereview_issue = state.get("codereview_issue")
# Include codereview issue number in patch name. This is a bit of a hack,
# but it makes doing the rietveld integration a lot easier.
if codereview_issue:
comment_text = "Feel free to provide comments at %s" % self._tool.codereview.url_for_issue(codereview_issue)
description += "-%s" % state["codereview_issue"]
self._tool.bugs.add_patch_to_bug(state["bug_id"], diff_file, description, comment_text=comment_text, mark_for_review=self._options.review, mark_for_commit_queue=self._options.request_commit)
if self._options.open_bug:
self._tool.user.open_url(self._tool.bugs.bug_url_for_bug_id(state["bug_id"]))
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment