Commit ac276574 authored by weinig's avatar weinig

LayoutTests:

        Reviewed by Adam Roben.

        * fast/dom/Window/alert-undefined-expected.txt: Added.
        * fast/dom/Window/alert-undefined.html: Added.

WebCore:

        Reviewed by Adam Roben.

        Convert JS undefined to the empty string when calling alert, confirm, and prompt. 

        Test: fast/dom/Window/alert-undefined.html

        * page/DOMWindow.idl:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 1f73104e
2007-07-17 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
* fast/dom/Window/alert-undefined-expected.txt: Added.
* fast/dom/Window/alert-undefined.html: Added.
2007-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Kevin McCulough.
ALERT:
The alert that shows up (or if this is running under DRT, that is dumped) should be blank and not contain the text "undefined".
<!DOCTYPE html>
<html>
<head>
<script type="text/javascript">
function runTests()
{
if (window.layoutTestController)
layoutTestController.dumpAsText();
alert();
}
</script>
</head>
<body onload="runTests();">
<p>The alert that shows up (or if this is running under DRT, that is dumped) should be blank and not contain the text "undefined".</p>
<pre id="console"></pre>
</body>
</html>
2007-07-17 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Convert JS undefined to the empty string when calling alert, confirm, and prompt.
Test: fast/dom/Window/alert-undefined.html
* page/DOMWindow.idl:
2007-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Kevin McCulough.
......@@ -47,10 +47,10 @@ module window {
void print();
void stop();
void alert(in DOMString message);
boolean confirm(in DOMString message);
[ConvertNullStringTo=Null] DOMString prompt(in [ConvertNullToNullString] DOMString message,
in [ConvertNullToNullString] DOMString defaultValue);
void alert(in [ConvertUndefinedOrNullToNullString] DOMString message);
boolean confirm(in [ConvertUndefinedOrNullToNullString] DOMString message);
[ConvertNullStringTo=Null] DOMString prompt(in [ConvertUndefinedOrNullToNullString] DOMString message,
in [ConvertUndefinedOrNullToNullString] DOMString defaultValue);
boolean find(in DOMString string,
in boolean caseSensitive,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment