Commit ab34f98a authored by harrison's avatar harrison
Browse files

Reviewed by Maciej.

        <rdar://problem/5009625> REGRESSION: Aperture 1.5: Can't select entire line of text after correcting a misspelled word

        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::respondToChangedSelection):
        * WebCoreSupport/WebFrameBridge.mm:
        Provide compatibility by not sending WebViewDidChangeSelectionNotification if
        the app is Aperture and is linked against WebKit 2.0.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 98726dac
2007-03-14 David Harrison <harrison@apple.com>
Reviewed by Maciej.
<rdar://problem/5009625> REGRESSION: Aperture 1.5: Can't select entire line of text after correcting a misspelled word
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::respondToChangedSelection):
* WebCoreSupport/WebFrameBridge.mm:
Provide compatibility by not sending WebViewDidChangeSelectionNotification if
the app is Aperture and is linked against WebKit 2.0.
2007-03-14 Anders Carlsson <acarlsson@apple.com> 2007-03-14 Anders Carlsson <acarlsson@apple.com>
   
Reviewed by Geoff. Reviewed by Geoff.
......
...@@ -41,8 +41,9 @@ ...@@ -41,8 +41,9 @@
#import "WebFrameInternal.h" #import "WebFrameInternal.h"
#import "WebHTMLView.h" #import "WebHTMLView.h"
#import "WebHTMLViewInternal.h" #import "WebHTMLViewInternal.h"
#import "WebLocalizableStrings.h"
#import "WebKitLogging.h" #import "WebKitLogging.h"
#import "WebKitVersionChecks.h"
#import "WebLocalizableStrings.h"
#import "WebNSURLExtras.h" #import "WebNSURLExtras.h"
#import "WebViewInternal.h" #import "WebViewInternal.h"
#import <WebCore/Document.h> #import <WebCore/Document.h>
...@@ -265,6 +266,11 @@ void WebEditorClient::respondToChangedSelection() ...@@ -265,6 +266,11 @@ void WebEditorClient::respondToChangedSelection()
NSView <WebDocumentView> *view = [[[m_webView selectedFrame] frameView] documentView]; NSView <WebDocumentView> *view = [[[m_webView selectedFrame] frameView] documentView];
if ([view isKindOfClass:[WebHTMLView class]]) if ([view isKindOfClass:[WebHTMLView class]])
[(WebHTMLView *)view _selectionChanged]; [(WebHTMLView *)view _selectionChanged];
// FIXME: This quirk is needed due to <rdar://problem/5009625> - We can phase it out once Aperture can adopt the new behavior on their end
if (!WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITHOUT_APERTURE_QUIRK) && [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.apple.Aperture"])
return;
[[NSNotificationCenter defaultCenter] postNotificationName:WebViewDidChangeSelectionNotification object:m_webView]; [[NSNotificationCenter defaultCenter] postNotificationName:WebViewDidChangeSelectionNotification object:m_webView];
} }
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment