Commit a945c700 authored by rwlbuis@webkit.org's avatar rwlbuis@webkit.org

Lonely stop crashes

https://bugs.webkit.org/show_bug.cgi?id=87964

Reviewed by Darin Adler.

Source/WebCore:

Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.

Test: svg/custom/stop-crash-hittest.svg

* rendering/svg/RenderSVGGradientStop.h:

LayoutTests:

Add testcase by taking stop-crash.svg and adding hittest instructions.

* svg/custom/stop-crash-hittest-expected.txt: Added.
* svg/custom/stop-crash-hittest.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 35ba0bb9
2013-08-26 Rob Buis <rwlbuis@webkit.org>
Lonely stop crashes
https://bugs.webkit.org/show_bug.cgi?id=87964
Reviewed by Darin Adler.
Add testcase by taking stop-crash.svg and adding hittest instructions.
* svg/custom/stop-crash-hittest-expected.txt: Added.
* svg/custom/stop-crash-hittest.svg: Added.
2013-08-26 Bem Jones-Bey <bjonesbe@adobe.com>
Optimize FloatIntervalSearchAdapter::collectIfNeeded
PASS -- if this test doesn't crash it passes.
<svg xmlns="http://www.w3.org/2000/svg">
<stop/>
<script>
if (window.testRunner)
testRunner.dumpAsText();
if (window.eventSender) {
eventSender.mouseMoveTo(200, 200);
eventSender.mouseDown();
eventSender.mouseUp();
}
</script>
<text x="10" y="25">PASS -- if this test doesn't crash it passes.</text>
</svg>
2013-08-26 Rob Buis <rwlbuis@webkit.org>
Lonely stop crashes
https://bugs.webkit.org/show_bug.cgi?id=87964
Reviewed by Darin Adler.
Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.
Test: svg/custom/stop-crash-hittest.svg
* rendering/svg/RenderSVGGradientStop.h:
2013-08-26 Sam Weinig <sam@webkit.org>
Editor::spellChecker() should return a reference
......@@ -47,6 +47,7 @@ public:
virtual FloatRect objectBoundingBox() const { return FloatRect(); }
virtual FloatRect strokeBoundingBox() const { return FloatRect(); }
virtual FloatRect repaintRectInLocalCoordinates() const { return FloatRect(); }
virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint&, HitTestAction) OVERRIDE { return false; }
protected:
virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment