Commit a924196b authored by apavlov@chromium.org's avatar apavlov@chromium.org
Browse files

2011-02-14 Alexander Pavlov <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: highlighter works incorrect at build.chromium.org WebKit cells
        https://bugs.webkit.org/show_bug.cgi?id=53910

        Use enclosingBoundingBox for the absolute margin quad as the reference box for a tooltip.

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::drawNodeHighlight):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 3a7f8734
2011-02-14 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: highlighter works incorrect at build.chromium.org WebKit cells
https://bugs.webkit.org/show_bug.cgi?id=53910
Use enclosingBoundingBox for the absolute margin quad as the reference box for a tooltip.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::drawNodeHighlight):
2011-02-15 Dirk Schulze <krit@webkit.org>
 
Rubber-stamped by Nikolas Zimmermann.
......@@ -1069,9 +1069,6 @@ void InspectorAgent::drawNodeHighlight(GraphicsContext& context) const
IntRect marginBox(borderBox.x() - renderBox->marginLeft(), borderBox.y() - renderBox->marginTop(),
borderBox.width() + renderBox->marginLeft() + renderBox->marginRight(), borderBox.height() + renderBox->marginTop() + renderBox->marginBottom());
titleReferenceBox = marginBox;
titleReferenceBox.move(mainFrameOffset);
titleReferenceBox.move(boundingBox.x(), boundingBox.y());
FloatQuad absContentQuad = renderBox->localToAbsoluteQuad(FloatRect(contentBox));
FloatQuad absPaddingQuad = renderBox->localToAbsoluteQuad(FloatRect(paddingBox));
......@@ -1083,6 +1080,8 @@ void InspectorAgent::drawNodeHighlight(GraphicsContext& context) const
absBorderQuad.move(mainFrameOffset);
absMarginQuad.move(mainFrameOffset);
titleReferenceBox = absMarginQuad.enclosingBoundingBox();
drawHighlightForBox(context, absContentQuad, absPaddingQuad, absBorderQuad, absMarginQuad);
} else if (renderer->isRenderInline() || isSVGRenderer) {
// FIXME: We should show margins/padding/border for inlines.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment