Commit a810bf1f authored by beidson's avatar beidson

Reviewed by Oliver

        Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
        For now, we have to not load favicons when we have no Document - linking directly 
        to PDFs being the common case

        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::startLoading): Check for the document and return if none



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 42aa0e35
2006-11-06 Brady Eidson <beidson@apple.com>
Reviewed by Oliver
Fixes <rdar://problem/4812674> and http://bugs.webkit.org/show_bug.cgi?id=11530
For now, we have to not load favicons when we have no Document - linking directly
to PDFs being the common case
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Check for the document and return if none
2006-11-06 Brady Eidson <beidson@apple.com>
Reviewed by Dave Harrison
......@@ -62,11 +62,13 @@ void IconLoader::startLoading()
m_httpStatusCode = 0;
// A frame may be documentless - one example is viewing a PDF directly
// FIXME - http://bugs.webkit.org/show_bug.cgi?id=10902
// Once the loader infrastructure will cleanly let us load an icon without a DocLoader, we can implement this
// A frame may be documentless - one example is viewing a PDF directly. Until the above FIXME is resolved,
// we must bail out early when we have no document
if (!m_frame->document()) {
// FIXME - http://bugzilla.opendarwin.org/show_bug.cgi?id=10902
// Once the loader infrastructure will cleanly let us load an icon without a DocLoader, we can implement this
LOG(IconDatabase, "Documentless-frame - icon won't be loaded");
return;
}
m_url = m_frame->iconURL();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment