Commit a7e66e1d authored by bweinstein@apple.com's avatar bweinstein@apple.com

2009-09-17 Brian Weinstein <bweinstein@apple.com>

        Reviewed by Adam Roben.

        Remove assertions that were being hit by calls to
        m_verticalScrollbar->invalidate(). These assertions were valid,
        but they were causing tests to fail, so replacing with a FIXME 
        until we can find out the real cause/solution that is being tracked 
        by http://webkit.org/b/29350.

        * WebView.cpp:
        (WebView::addToDirtyRegion):
        (WebView::paintIntoBackingStore):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 8911af2f
2009-09-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Remove assertions that were being hit by calls to
m_verticalScrollbar->invalidate(). These assertions were valid,
but they were causing tests to fail, so replacing with a FIXME
until we can find out the real cause/solution that is being tracked
by http://webkit.org/b/29350.
* WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::paintIntoBackingStore):
2009-09-17 Ada Chan <adachan@apple.com>
Post WebViewDidChangeSelectionNotification when the text selection changes.
......
......@@ -723,6 +723,10 @@ bool WebView::ensureBackingStore()
void WebView::addToDirtyRegion(const IntRect& dirtyRect)
{
// FIXME: We want an assert here saying that the dirtyRect is inside the clienRect,
// but it was being hit during our layout tests, and is being investigated in
// http://webkit.org/b/29350.
HRGN newRegion = ::CreateRectRgn(dirtyRect.x(), dirtyRect.y(),
dirtyRect.right(), dirtyRect.bottom());
addToDirtyRegion(newRegion);
......@@ -949,11 +953,9 @@ void WebView::paintIntoBackingStore(FrameView* frameView, HDC bitmapDC, const In
{
LOCAL_GDI_COUNTER(0, __FUNCTION__);
#if !ASSERT_DISABLED
RECT clientRect;
GetClientRect(m_viewWindow, &clientRect);
ASSERT(IntRect(clientRect).contains(dirtyRect));
#endif
// FIXME: We want an assert here saying that the dirtyRect is inside the clienRect,
// but it was being hit during our layout tests, and is being investigated in
// http://webkit.org/b/29350.
RECT rect = dirtyRect;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment