From a62349b1bc7f24de4b4084e3bf87d227ce99e953 Mon Sep 17 00:00:00 2001 From: "commit-queue@webkit.org" Date: Fri, 20 Dec 2013 05:52:56 +0000 Subject: [PATCH] Web Inspector: Frontend Error when selecting Database folder in Resources Sidebar https://bugs.webkit.org/show_bug.cgi?id=126029 Patch by Joseph Pecoraro on 2013-12-19 Reviewed by Timothy Hatcher. Treat the DatabaseHostTreeElement tree element like a folder. It pretty much is a folder, but inherits from StorageTreeElement to share some code there. * UserInterface/ResourceSidebarPanel.js: (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160897 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/WebInspectorUI/ChangeLog | 13 +++++++++++++ .../UserInterface/ResourceSidebarPanel.js | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Source/WebInspectorUI/ChangeLog b/Source/WebInspectorUI/ChangeLog index 6c9e55e41db..9eebad5265d 100644 --- a/Source/WebInspectorUI/ChangeLog +++ b/Source/WebInspectorUI/ChangeLog @@ -1,3 +1,16 @@ +2013-12-19 Joseph Pecoraro + + Web Inspector: Frontend Error when selecting Database folder in Resources Sidebar + https://bugs.webkit.org/show_bug.cgi?id=126029 + + Reviewed by Timothy Hatcher. + + Treat the DatabaseHostTreeElement tree element like a folder. It pretty much + is a folder, but inherits from StorageTreeElement to share some code there. + + * UserInterface/ResourceSidebarPanel.js: + (WebInspector.ResourceSidebarPanel.prototype._treeElementSelected): + 2013-12-19 Joseph Pecoraro Web Inspector: Uncaught Exception: NavigationSidebarPanel.js: TypeError: undefined is not a function diff --git a/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js b/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js index fbb400a47ae..1df8c23292c 100644 --- a/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js +++ b/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js @@ -622,7 +622,7 @@ WebInspector.ResourceSidebarPanel.prototype = { _treeElementSelected: function(treeElement, selectedByUser) { - if (treeElement instanceof WebInspector.FolderTreeElement) + if (treeElement instanceof WebInspector.FolderTreeElement || treeElement instanceof WebInspector.DatabaseHostTreeElement) return; if (treeElement instanceof WebInspector.ResourceTreeElement || treeElement instanceof WebInspector.ScriptTreeElement || -- GitLab