Commit a30cf776 authored by leoyang@rim.com's avatar leoyang@rim.com

Lots of unused parameter warnings in filesystem code

https://bugs.webkit.org/show_bug.cgi?id=114747

Reviewed by Carlos Garcia Campos.

Comment out or remove unused parameter identifiers.

No functionalities changed, no new tests.

* Modules/filesystem/DOMFileSystem.cpp: Comment out |snapshot| because
it is referred in the comments inside the function.
(WebCore):
* Modules/filesystem/DOMFileSystemSync.cpp: Ditto.
(WebCore):
* Modules/filesystem/FileWriter.cpp: Remove unused |ec|.
(WebCore::FileWriter::abort):
* Modules/filesystem/FileWriterSync.cpp:
(WebCore::FileWriterSync::didWrite): Remove unused |bytes|.
* platform/AsyncFileSystemCallbacks.h:
(WebCore::AsyncFileSystemCallbacks::didOpenFileSystem): Comment out unused parameters
because the function is inlined.
(WebCore::AsyncFileSystemCallbacks::didCreateSnapshotFile): Ditto.
(WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntry): Ditto.
(WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntries): Ditto.
(WebCore::AsyncFileSystemCallbacks::didCreateFileWriter): Ditto.
* platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread): Remove unused |client|.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 92d7c3f2
2013-04-17 Leo Yang <leoyang@rim.com>
Lots of unused parameter warnings in filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114747
Reviewed by Carlos Garcia Campos.
Comment out or remove unused parameter identifiers.
No functionalities changed, no new tests.
* Modules/filesystem/DOMFileSystem.cpp: Comment out |snapshot| because
it is referred in the comments inside the function.
(WebCore):
* Modules/filesystem/DOMFileSystemSync.cpp: Ditto.
(WebCore):
* Modules/filesystem/FileWriter.cpp: Remove unused |ec|.
(WebCore::FileWriter::abort):
* Modules/filesystem/FileWriterSync.cpp:
(WebCore::FileWriterSync::didWrite): Remove unused |bytes|.
* platform/AsyncFileSystemCallbacks.h:
(WebCore::AsyncFileSystemCallbacks::didOpenFileSystem): Comment out unused parameters
because the function is inlined.
(WebCore::AsyncFileSystemCallbacks::didCreateSnapshotFile): Ditto.
(WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntry): Ditto.
(WebCore::AsyncFileSystemCallbacks::didReadDirectoryEntries): Ditto.
(WebCore::AsyncFileSystemCallbacks::didCreateFileWriter): Ditto.
* platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread): Remove unused |client|.
2013-04-17 Brent Fulgham <bfulgham@webkit.org>
[Windows, WinCairo] Stop individually building WTF files in WebCore
......@@ -155,7 +155,7 @@ public:
return adoptPtr(new SnapshotFileCallback(filesystem, name, url, successCallback, errorCallback));
}
virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> snapshot)
virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> /* snapshot */)
{
ASSERT(!metadata.platformPath.isEmpty());
if (!m_successCallback)
......
......@@ -113,7 +113,7 @@ public:
{
}
virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> snapshot)
virtual void didCreateSnapshotFile(const FileMetadata& metadata, PassRefPtr<BlobDataHandle> /* snapshot */)
{
// We can't directly use the snapshot blob data handle because the content type on it hasn't been set.
// The |snapshot| param is here to provide a a chain of custody thru thread bridging that is held onto until
......
......@@ -168,7 +168,7 @@ void FileWriter::truncate(long long position, ExceptionCode& ec)
fireEvent(eventNames().writestartEvent);
}
void FileWriter::abort(ExceptionCode& ec)
void FileWriter::abort(ExceptionCode&)
{
ASSERT(writer());
if (m_readyState != WRITING)
......
......@@ -91,7 +91,7 @@ void FileWriterSync::truncate(long long offset, ExceptionCode& ec)
setLength(offset);
}
void FileWriterSync::didWrite(long long bytes, bool complete)
void FileWriterSync::didWrite(long long, bool complete)
{
ASSERT(m_error == FileError::OK);
ASSERT(!m_complete);
......
......@@ -50,22 +50,22 @@ public:
virtual void didSucceed() { ASSERT_NOT_REACHED(); }
// Called when a requested file system is opened.
virtual void didOpenFileSystem(const String& name, const KURL& rootURL, PassOwnPtr<AsyncFileSystem>) { ASSERT_NOT_REACHED(); }
virtual void didOpenFileSystem(const String& /* name */, const KURL& /* rootURL */, PassOwnPtr<AsyncFileSystem>) { ASSERT_NOT_REACHED(); }
// Called when a file metadata is read successfully.
virtual void didReadMetadata(const FileMetadata&) { ASSERT_NOT_REACHED(); }
// Called when a snapshot file is created successfully.
virtual void didCreateSnapshotFile(const FileMetadata&, PassRefPtr<BlobDataHandle> snapshot) { ASSERT_NOT_REACHED(); }
virtual void didCreateSnapshotFile(const FileMetadata&, PassRefPtr<BlobDataHandle> /* snapshot */) { ASSERT_NOT_REACHED(); }
// Called when a directory entry is read.
virtual void didReadDirectoryEntry(const String& name, bool isDirectory) { ASSERT_NOT_REACHED(); }
virtual void didReadDirectoryEntry(const String& /* name */, bool /* isDirectory */) { ASSERT_NOT_REACHED(); }
// Called after a chunk of directory entries have been read (i.e. indicates it's good time to call back to the application). If hasMore is true there can be more chunks.
virtual void didReadDirectoryEntries(bool hasMore) { ASSERT_NOT_REACHED(); }
virtual void didReadDirectoryEntries(bool /* hasMore */) { ASSERT_NOT_REACHED(); }
// Called when an AsyncFileWrter has been created successfully.
virtual void didCreateFileWriter(PassOwnPtr<AsyncFileWriter>, long long length) { ASSERT_NOT_REACHED(); }
virtual void didCreateFileWriter(PassOwnPtr<AsyncFileWriter>, long long /* length */) { ASSERT_NOT_REACHED(); }
// Called when there was an error.
virtual void didFail(int code) = 0;
......
......@@ -119,7 +119,7 @@ void WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread(ScriptExecutionC
platformFileSystem->readDirectory(fileSystemURLToPath(path).utf8().data(), callbacks);
}
void WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread(ScriptExecutionContext*, WebFileSystem* platformFileSystem, AsyncFileWriterClient* client, const KURL& path, WorkerPlatformAsyncFileSystemCallbacks* callbacks)
void WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread(ScriptExecutionContext*, WebFileSystem* platformFileSystem, AsyncFileWriterClient*, const KURL& path, WorkerPlatformAsyncFileSystemCallbacks* callbacks)
{
WebFileWriter::createWriter(platformFileSystem, fileSystemURLToPath(path).utf8().data(), callbacks);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment