Commit a0669293 authored by eric@webkit.org's avatar eric@webkit.org
Browse files

2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Evaluate and create tests for all the AtkRole's implemented by
        WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=34449

        Implement ATK_ROLE_COMBO_BOX.

        * accessibility/gtk/AccessibilityObjectAtk.cpp:
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (atkRole):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 9b55932f
2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
Reviewed by Xan Lopez.
[Gtk] Evaluate and create tests for all the AtkRole's implemented by
WebKitGtk
https://bugs.webkit.org/show_bug.cgi?id=34449
Implement ATK_ROLE_COMBO_BOX.
* accessibility/gtk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(atkRole):
2010-04-22 Nikolas Zimmermann <nzimmermann@rim.com> 2010-04-22 Nikolas Zimmermann <nzimmermann@rim.com>
   
Reviewed by Dirk Schulze. Reviewed by Dirk Schulze.
...@@ -38,9 +38,6 @@ AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesO ...@@ -38,9 +38,6 @@ AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesO
if (!parent) if (!parent)
return DefaultBehavior; return DefaultBehavior;
if (isMenuListPopup() || isMenuListOption())
return IgnoreObject;
if (roleValue() == SplitterRole) if (roleValue() == SplitterRole)
return IncludeObject; return IncludeObject;
......
...@@ -360,8 +360,10 @@ static AtkRole atkRole(AccessibilityRole role) ...@@ -360,8 +360,10 @@ static AtkRole atkRole(AccessibilityRole role)
return ATK_ROLE_TREE; return ATK_ROLE_TREE;
case MenuBarRole: case MenuBarRole:
return ATK_ROLE_MENU_BAR; return ATK_ROLE_MENU_BAR;
case MenuListPopupRole:
case MenuRole: case MenuRole:
return ATK_ROLE_MENU; return ATK_ROLE_MENU;
case MenuListOptionRole:
case MenuItemRole: case MenuItemRole:
return ATK_ROLE_MENU_ITEM; return ATK_ROLE_MENU_ITEM;
case ColumnRole: case ColumnRole:
...@@ -379,6 +381,7 @@ static AtkRole atkRole(AccessibilityRole role) ...@@ -379,6 +381,7 @@ static AtkRole atkRole(AccessibilityRole role)
return ATK_ROLE_PROGRESS_BAR; return ATK_ROLE_PROGRESS_BAR;
case WindowRole: case WindowRole:
return ATK_ROLE_WINDOW; return ATK_ROLE_WINDOW;
case PopUpButtonRole:
case ComboBoxRole: case ComboBoxRole:
return ATK_ROLE_COMBO_BOX; return ATK_ROLE_COMBO_BOX;
case SplitGroupRole: case SplitGroupRole:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment