Commit a05eb14a authored by mjs@apple.com's avatar mjs@apple.com

2008-10-17 Maciej Stachowiak <mjs@apple.com>

        Reviewed by Mark Rowe.
        
        - make sure MallocStackLogging is only on for tools we want to
        leak check, not other random stuff as well.

        * Scripts/run-webkit-tests:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent f6fee0bc
2008-10-17 Maciej Stachowiak <mjs@apple.com>
Reviewed by Mark Rowe.
- make sure MallocStackLogging is only on for tools we want to
leak check, not other random stuff as well.
* Scripts/run-webkit-tests:
2008-10-17 Maciej Stachowiak <mjs@apple.com>
Reviewed by Stephanie Lewis.
......
......@@ -477,6 +477,7 @@ if ($pixelTests) {
local %ENV;
$ENV{MallocStackLogging} = 1 if $shouldCheckLeaks;
$imageDiffToolPID = open2(\*DIFFIN, \*DIFFOUT, $imageDiffTool, @diffToolArgs) or die "unable to open $imageDiffTool\n";
$ENV{MallocStackLogging} = 0 if $shouldCheckLeaks;
}
my $dumpToolPID;
......@@ -1188,7 +1189,6 @@ sub openDumpTool()
}
$ENV{DYLD_FRAMEWORK_PATH} = $productDir;
$ENV{XML_CATALOG_FILES} = ""; # work around missing /etc/catalog <rdar://problem/4292995>
$ENV{MallocStackLogging} = 1 if $shouldCheckLeaks;
$ENV{DYLD_INSERT_LIBRARIES} = "/usr/lib/libgmalloc.dylib" if $guardMalloc;
if (isCygwin()) {
......@@ -1211,7 +1211,9 @@ sub openDumpTool()
unshift @args, "valgrind";
}
$ENV{MallocStackLogging} = 1 if $shouldCheckLeaks;
$dumpToolPID = open3(\*OUT, \*IN, \*ERROR, @args) or die "Failed to start tool: $dumpTool\n";
$ENV{MallocStackLogging} = 1 if $shouldCheckLeaks;
$isDumpToolOpen = 1;
$dumpToolCrashed = 0;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment