Commit 9ad4f446 authored by shinyak@chromium.org's avatar shinyak@chromium.org

[Refatoring] Remove ElementShadow::insertionPointFor

https://bugs.webkit.org/show_bug.cgi?id=100625

Reviewed by Hajime Morita.

Now that ElementShadow::insertionPointFor does not do any special things, and it's only used in
ComposedShadowTreeWalker. So we can remove it.

No new tests, simple refactoring.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::resolveReprojection):
(WebCore::AncestorChainWalker::parent):
* dom/ElementShadow.cpp:
* dom/ElementShadow.h:
(ElementShadow):
* dom/ShadowRoot.h: ShadowRoot has insertionPointFor declaration, but we don't have any implementation.
We should remove it.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 64d33e16
2012-10-29 Shinya Kawanaka <shinyak@chromium.org>
[Refatoring] Remove ElementShadow::insertionPointFor
https://bugs.webkit.org/show_bug.cgi?id=100625
Reviewed by Hajime Morita.
Now that ElementShadow::insertionPointFor does not do any special things, and it's only used in
ComposedShadowTreeWalker. So we can remove it.
No new tests, simple refactoring.
* dom/ComposedShadowTreeWalker.cpp:
(WebCore::resolveReprojection):
(WebCore::AncestorChainWalker::parent):
* dom/ElementShadow.cpp:
* dom/ElementShadow.h:
(ElementShadow):
* dom/ShadowRoot.h: ShadowRoot has insertionPointFor declaration, but we don't have any implementation.
We should remove it.
2012-10-29 Andy Estes <aestes@apple.com>
Fix a typo that caused SVG external resources to be blocked on
......@@ -88,7 +88,7 @@ static inline InsertionPoint* resolveReprojection(const Node* projectedNode)
while (true) {
if (ElementShadow* shadow = shadowOfParentForDistribution(current)) {
shadow->ensureDistribution();
if (InsertionPoint* insertedTo = shadow->insertionPointFor(projectedNode)) {
if (InsertionPoint* insertedTo = shadow->distributor().findInsertionPointFor(projectedNode)) {
current = insertedTo;
insertionPoint = insertedTo;
continue;
......@@ -395,7 +395,7 @@ void AncestorChainWalker::parent()
ASSERT(m_node);
ASSERT(m_distributedNode);
if (ElementShadow* shadow = shadowOfParent(m_node)) {
if (InsertionPoint* insertionPoint = shadow->insertionPointFor(m_distributedNode)) {
if (InsertionPoint* insertionPoint = shadow->distributor().findInsertionPointFor(m_distributedNode)) {
m_node = insertionPoint;
m_isCrossingInsertionPoint = true;
return;
......
......@@ -132,11 +132,6 @@ void ElementShadow::detach()
}
}
InsertionPoint* ElementShadow::insertionPointFor(const Node* node) const
{
return distributor().findInsertionPointFor(node);
}
bool ElementShadow::childNeedsStyleRecalc()
{
ASSERT(youngestShadowRoot());
......
......@@ -65,8 +65,6 @@ public:
void setValidityUndetermined();
void invalidateDistribution();
void ensureDistribution();
InsertionPoint* insertionPointFor(const Node*) const;
ContentDistributor& distributor();
const ContentDistributor& distributor() const;
......
......@@ -59,8 +59,6 @@ public:
void recalcShadowTreeStyle(StyleChange);
InsertionPoint* insertionPointFor(Node*) const;
virtual bool applyAuthorStyles() const OVERRIDE;
void setApplyAuthorStyles(bool);
virtual bool resetStyleInheritance() const OVERRIDE;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment