[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash

https://bugs.webkit.org/show_bug.cgi?id=86961

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add ecore_x initialisation check before calling ecore_x_bell
to avoid crashes when X server is not running.

* platform/efl/SoundEfl.cpp:
(WebCore::systemBeep):

LayoutTests:

Unskipped two layout tests that were crashing.

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 5f30dea0
2012-09-04 Alexander Shalamov <alexander.shalamov@intel.com>
[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
https://bugs.webkit.org/show_bug.cgi?id=86961
Reviewed by Kenneth Rohde Christiansen.
Unskipped two layout tests that were crashing.
* platform/efl/TestExpectations:
2012-09-04 Alexander Shalamov <alexander.shalamov@intel.com>
[EFL][WK2] CSS3 Media Queries functionality is broken
......@@ -759,10 +759,6 @@ BUGWK86597 : fullscreen/video-controls-drag.html = TEXT
BUGWK86187 : media/media-fullscreen-not-in-document.html = TEXT
BUGWK86187 SKIP : media/media-fullscreen-inline.html = PASS
// ecore_x library is not initialized and calls to it cause crashes
BUGWK86961 : editing/execCommand/paste-and-match-style-event.html = CRASH
BUGWK86961 : fast/dom/shadow/cppevent-in-shadow.html = CRASH
// Selection problem in Shadow DOM test (passes on GTK)
BUGWKEFL : fast/dom/shadow/selections-in-shadow.html = TEXT
......
2012-09-04 Alexander Shalamov <alexander.shalamov@intel.com>
[EFL] Check if ecore_x is initialised before calling ecore_x_bell to avoid crash
https://bugs.webkit.org/show_bug.cgi?id=86961
Reviewed by Kenneth Rohde Christiansen.
Add ecore_x initialisation check before calling ecore_x_bell
to avoid crashes when X server is not running.
* platform/efl/SoundEfl.cpp:
(WebCore::systemBeep):
2012-09-04 Alexander Shalamov <alexander.shalamov@intel.com>
[EFL][WK2] CSS3 Media Queries functionality is broken
......@@ -39,7 +39,10 @@ namespace WebCore {
void systemBeep()
{
#ifdef HAVE_ECORE_X
ecore_x_bell(0);
if (ecore_x_init(0)) {
ecore_x_bell(0);
ecore_x_shutdown();
}
#endif
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment