Commit 94d82cdc authored by keishi@webkit.org's avatar keishi@webkit.org
Browse files

REGRESSION (r129738): Calendar picker is too wide when the input is rtl

https://bugs.webkit.org/show_bug.cgi?id=98881

.:

Reviewed by kent Tamura.

* ManualTests/forms/calendar-picker.html: Added isCalendarRTL parameters.

Source/WebCore:

Reviewed by Kent Tamura.

Calendar picker should use param.isCalendarRTL instead of param.isRTL but some were left.

No new tests. Covered by ManualTests/forms/calendar-picker.html.

* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Calendar picker should use param.isCalendarRTL instead of param.isRTL.
(DaysTable.prototype._handleKey): Ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent c6e67999
2012-10-10 Keishi Hattori <keishi@webkit.org>
REGRESSION (r129738): Calendar picker is too wide when the input is rtl
https://bugs.webkit.org/show_bug.cgi?id=98881
Reviewed by kent Tamura.
* ManualTests/forms/calendar-picker.html: Added isCalendarRTL parameters.
2012-10-10 Christophe Dumez <christophe.dumez@intel.com>
[EFL][WK2] Port MiniBrowser to Elementary
......
......@@ -64,7 +64,8 @@ var japaneseArguments = {
};
var arabicArguments = {
locale: 'ar',
isRTL: true,
isRTL: false,
isCalendarRTL: true,
monthLabels : ['يناير', 'فبراير', 'مارس', 'أبريل', 'مايو', 'يونيو',
'يوليو', 'أغسطس', 'سبتمبر', 'أكتوبر', 'نوفمبر', 'ديسمبر'],
dayLabels : ['ح', 'ن', 'ث', 'ر', 'خ', 'ج', 'س'],
......@@ -158,6 +159,7 @@ var longDatalistArguments = {
var arabicDatalistArguments = {
locale: 'ar',
isRTL: true,
isCalendarRTL: true,
monthLabels : ['يناير', 'فبراير', 'مارس', 'أبريل', 'مايو', 'يونيو',
'يوليو', 'أغسطس', 'سبتمبر', 'أكتوبر', 'نوفمبر', 'ديسمبر'],
dayLabels : ['ح', 'ن', 'ث', 'ر', 'خ', 'ج', 'س'],
......@@ -180,6 +182,7 @@ var arabicDatalistArguments = {
var arabicLongDatalistArguments = {
locale: 'ar',
isRTL: true,
isCalendarRTL: true,
monthLabels : ['يناير', 'فبراير', 'مارس', 'أبريل', 'مايو', 'يونيو',
'يوليو', 'أغسطس', 'سبتمبر', 'أكتوبر', 'نوفمبر', 'ديسمبر'],
dayLabels : ['ح', 'ن', 'ث', 'ر', 'خ', 'ج', 'س'],
......
2012-10-10 Keishi Hattori <keishi@webkit.org>
REGRESSION (r129738): Calendar picker is too wide when the input is rtl
https://bugs.webkit.org/show_bug.cgi?id=98881
Reviewed by Kent Tamura.
Calendar picker should use param.isCalendarRTL instead of param.isRTL but some were left.
No new tests. Covered by ManualTests/forms/calendar-picker.html.
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize): Calendar picker should use param.isCalendarRTL instead of param.isRTL.
(DaysTable.prototype._handleKey): Ditto.
2012-10-10 Alexander Pavlov <apavlov@chromium.org>
Web Inspector: Semantically incorrect CSS rules result in broken source code data
......
......@@ -375,7 +375,7 @@ CalendarPicker.prototype.fixWindowSize = function() {
var DaysAreaContainerBorder = 1;
var yearMonthEnd;
var daysAreaEnd;
if (global.params.isRTL) {
if (global.params.isCalendarRTL) {
var startOffset = this._element.offsetLeft + this._element.offsetWidth;
yearMonthEnd = startOffset - yearMonthRightElement.offsetLeft;
daysAreaEnd = startOffset - (daysAreaElement.offsetLeft + daysAreaElement.offsetWidth) + maxCellWidth * 7 + DaysAreaContainerBorder;
......@@ -1089,7 +1089,7 @@ DaysTable.prototype._handleKey = function(event) {
return;
}
if (key == (global.params.isRTL ? "Right" : "Left")) {
if (key == (global.params.isCalendarRTL ? "Right" : "Left")) {
if (x == 0) {
if (y == 0) {
if (!this._maybeSetPreviousMonth())
......@@ -1111,7 +1111,7 @@ DaysTable.prototype._handleKey = function(event) {
y--;
this.updateSelection(event, x, y);
} else if (key == (global.params.isRTL ? "Left" : "Right")) {
} else if (key == (global.params.isCalendarRTL ? "Left" : "Right")) {
if (x == 6) {
if (y == DaysTable._Weeks - 1) {
if (!this._maybeSetNextMonth())
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment