Commit 91dde07e authored by andersca's avatar andersca

2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Remove most annoying notImplemented() usages and
        implement some missing ScrollViewQt functions.
        Much nicer output when invoking run-webkit-tests.

        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::saveDocumentState):
        (WebCore::FrameQt::restoreDocumentState):
        (WebCore::FrameQt::clearUndoRedoOperations):
        (WebCore::FrameQt::partClearedInBegin):
        * platform/qt/ResourceLoaderManager.cpp:
        (WebCore::headerCallback):
        (WebCore::ResourceLoaderManager::downloadTimerCallback):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::updateContents):
        (WebCore::ScrollView::suppressScrollBars):
        (WebCore::ScrollView::setStaticBackground):
        (WebCore::ScrollView::addChild):
        (WebCore::ScrollView::removeChild):
        * platform/qt/TemporaryLinkStubs.cpp:
        (WebCore::historyContains):
        (WebCore::CheckCacheObjectStatus):
        (WebCore::CheckIfReloading):
        (loadResourceIntoArray):
        (WebCore::PlugInInfoStore::supportsMIMEType):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 8efa6506
2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Remove most annoying notImplemented() usages and
implement some missing ScrollViewQt functions.
Much nicer output when invoking run-webkit-tests.
* platform/qt/FrameQt.cpp:
(WebCore::FrameQt::saveDocumentState):
(WebCore::FrameQt::restoreDocumentState):
(WebCore::FrameQt::clearUndoRedoOperations):
(WebCore::FrameQt::partClearedInBegin):
* platform/qt/ResourceLoaderManager.cpp:
(WebCore::headerCallback):
(WebCore::ResourceLoaderManager::downloadTimerCallback):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::updateContents):
(WebCore::ScrollView::suppressScrollBars):
(WebCore::ScrollView::setStaticBackground):
(WebCore::ScrollView::addChild):
(WebCore::ScrollView::removeChild):
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::historyContains):
(WebCore::CheckCacheObjectStatus):
(WebCore::CheckIfReloading):
(loadResourceIntoArray):
(WebCore::PlugInInfoStore::supportsMIMEType):
2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
......
......@@ -315,12 +315,12 @@ bool FrameQt::lastEventIsMouseUp() const
void FrameQt::saveDocumentState()
{
notImplemented();
// FIXME: Implement this as soon a KPart is created...
}
void FrameQt::restoreDocumentState()
{
notImplemented();
// FIXME: Implement this as soon a KPart is created...
}
void FrameQt::openURLRequest(const ResourceRequest&)
......@@ -389,7 +389,7 @@ void FrameQt::registerCommandForRedo(PassRefPtr<EditCommand>)
void FrameQt::clearUndoRedoOperations()
{
notImplemented();
// FIXME: Implement this as soon a KPart is created...
}
void FrameQt::issueUndoCommand()
......@@ -445,7 +445,9 @@ bool FrameQt::shouldChangeSelection(const SelectionController& oldSelection, con
void FrameQt::partClearedInBegin()
{
notImplemented();
// FIXME: This is only related to the js debugger.
// See WebCoreSupport/WebFrameBridge.m "windowObjectCleared",
// which is called by FrameMac::partClearedInBegin() ...
}
bool FrameQt::canGoBackOrForward(int distance) const
......
......@@ -72,7 +72,6 @@ static size_t writeCallback(void* ptr, size_t size, size_t nmemb, void* obj)
static size_t headerCallback(char* ptr, size_t size, size_t nmemb, void* obj)
{
ResourceLoader* job = static_cast<ResourceLoader*>(obj);
ResourceLoaderInternal* d = job->getInternal();
if (job->method() == "POST")
job->receivedResponse(ptr);
......@@ -116,14 +115,8 @@ void ResourceLoaderManager::downloadTimerCallback(Timer<ResourceLoaderManager>*
retval = ::select(maxfd + 1, &fdread, &fdwrite, &fdexcep, &timeout);
switch (retval) {
case -1: // select error
#ifndef NDEBUG
printf("%s, select error(%d)\n", __PRETTY_FUNCTION__,retval);
#endif
/* fallthrough*/
case 0: // select timeout
#ifndef NDEBUG
printf("%s, select timeout %d\n", __PRETTY_FUNCTION__,retval);
#endif
/* fallthrough. this can be the first perform to be made */
default: // 1+ descriptors have data
while (CURLM_CALL_MULTI_PERFORM == curl_multi_perform(curlMultiHandle, &nrunning))
......@@ -132,7 +125,6 @@ void ResourceLoaderManager::downloadTimerCallback(Timer<ResourceLoaderManager>*
// check the curl messages indicating completed transfers
// and free their resources
ResourceLoader* job;
int nmsgs;
while (CURLMsg* msg = curl_multi_info_read(curlMultiHandle, &nmsgs)) {
if (msg->msg == CURLMSG_DONE) {
......
......@@ -68,6 +68,7 @@ void ScrollView::setParentWidget(QWidget* parent)
void ScrollView::updateContents(const IntRect& updateRect, bool now)
{
// FIXME: We don't force updating with now=true here...
if (m_area->widget())
m_area->widget()->update(updateRect);
}
......@@ -184,7 +185,8 @@ ScrollBarMode ScrollView::vScrollBarMode() const
void ScrollView::suppressScrollBars(bool suppressed, bool repaintOnSuppress)
{
notImplemented();
// FIXME: Is this correct?
setScrollBarsMode(ScrollBarAlwaysOff);
}
void ScrollView::setHScrollBarMode(ScrollBarMode newMode)
......@@ -227,7 +229,7 @@ void ScrollView::setScrollBarsMode(ScrollBarMode newMode)
void ScrollView::setStaticBackground(bool flag)
{
notImplemented();
// no-op
}
void ScrollView::addChild(Widget* child, int x, int y)
......@@ -235,12 +237,16 @@ void ScrollView::addChild(Widget* child, int x, int y)
Q_ASSERT(child != 0);
Q_ASSERT(m_area && m_area->widget());
// Ignore offscreen position initialization
if (x != -500000)
child->move(x, y);
child->setParentWidget(m_area->widget());
}
void ScrollView::removeChild(Widget*)
{
notImplemented();
// no-op
}
void ScrollView::scrollPointRecursively(int x, int y)
......
......@@ -138,12 +138,12 @@ void PlatformScrollBar::setRect(const IntRect&) { notImplemented(); }
PlatformMouseEvent::PlatformMouseEvent(const CurrentEventTag&) { notImplemented(); }
void CheckCacheObjectStatus(DocLoader*, CachedResource*) { notImplemented(); }
bool CheckIfReloading(WebCore::DocLoader*) { notImplemented(); return false; }
void CheckCacheObjectStatus(DocLoader*, CachedResource*) { }
bool CheckIfReloading(WebCore::DocLoader*) { return false; }
Vector<char> ServeSynchronousRequest(Loader*, DocLoader*, ResourceLoader*, KURL&, DeprecatedString&) { notImplemented(); return Vector<char>(); }
}
bool WebCore::historyContains(DeprecatedString const&) { notImplemented(); return false; }
bool WebCore::historyContains(DeprecatedString const&) { return false; }
String WebCore::submitButtonDefaultLabel() { return "Submit"; }
String WebCore::inputElementAltText() { return DeprecatedString(); }
String WebCore::resetButtonDefaultLabel() { return "Reset"; }
......@@ -168,11 +168,11 @@ void FrameView::updateBorder() { notImplemented(); }
bool AXObjectCache::gAccessibilityEnabled = false;
Vector<char> loadResourceIntoArray(const char* ) { notImplemented(); return Vector<char>(); }
Vector<char> loadResourceIntoArray(const char*) { return Vector<char>(); }
PluginInfo* PlugInInfoStore::createPluginInfoForPluginAtIndex(unsigned) { notImplemented(); return 0; }
unsigned PlugInInfoStore::pluginCount() const { notImplemented(); return 0; }
bool WebCore::PlugInInfoStore::supportsMIMEType(const WebCore::String&) { notImplemented(); return false; }
bool WebCore::PlugInInfoStore::supportsMIMEType(const WebCore::String&) { return false; }
FileButton::FileButton(Frame*) { notImplemented(); }
void FileButton::click(bool) { notImplemented(); }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment