Commit 8ece1dac authored by sfalken@apple.com's avatar sfalken@apple.com
Browse files

WebView drawing code may access null backing store dirty region

https://bugs.webkit.org/show_bug.cgi?id=38245
<rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)
        
Reviewed by Maciej Stachowiak.

* WebView.cpp:
(WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent fbee9667
2010-04-28 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
WebView drawing code may access null backing store dirty region
https://bugs.webkit.org/show_bug.cgi?id=38245
<rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)
* WebView.cpp:
(WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.
2010-04-27 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/7911140> Hitting the "delete" key goes back twice
......
......@@ -904,7 +904,7 @@ void WebView::updateBackingStore(FrameView* frameView, HDC dc, bool backingStore
view->layoutIfNeededRecursive();
Vector<IntRect> paintRects;
if (!backingStoreCompletelyDirty) {
if (!backingStoreCompletelyDirty && m_backingStoreDirtyRegion) {
RECT regionBox;
::GetRgnBox(m_backingStoreDirtyRegion->handle(), &regionBox);
getUpdateRects(m_backingStoreDirtyRegion->handle(), regionBox, paintRects);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment