From 8e5df79d7272a36e7c431e99ebf5d79d19ecd82c Mon Sep 17 00:00:00 2001 From: "sergio@webkit.org" Date: Wed, 28 Aug 2013 09:29:30 +0000 Subject: [PATCH] [Soup] WebTiming information not shown in the inspector https://bugs.webkit.org/show_bug.cgi?id=118395 Reviewed by Martin Robinson. Source/WebCore: WebTiming information was not correctly provided to WebCore because the gotHeadersCallback was incorrectly resetting the original ResourceResponse (which had the ResourceLoadTiming object) instead of simply updating their contents using the SoupMessage. No new test required as this feature is already covered by the existing webtiming tests. In any case this change includes a fix for the http/tests/misc/webtiming-ssl.php test which was not failing even if it should because it was not correct. * platform/network/soup/ResourceHandleSoup.cpp: (WebCore::gotHeadersCallback): (WebCore::restartedCallback): restartedCallback should be available only if WEB_TIMING is defined. (WebCore::createSoupMessageForHandleAndRequest): Ditto. LayoutTests: Fixed the webiming-ssl.php test that was incorrectly considering a FAIL as the expected result. It was probably just a legacy decision which came from the times where DRT was responsible of reporting WebTiming information. Also added a new test that fails due to wkb.ug/103927. It was not detected before because there were no timing information in the response. * http/tests/misc/resources/webtiming-ssl.html: * http/tests/misc/webtiming-ssl-expected.txt: * platform/gtk/TestExpectations: added http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154727 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- LayoutTests/ChangeLog | 21 ++++++++++++++++ .../tests/misc/resources/webtiming-ssl.html | 2 +- .../tests/misc/webtiming-ssl-expected.txt | 4 ++-- LayoutTests/platform/gtk/TestExpectations | 1 + Source/WebCore/ChangeLog | 24 +++++++++++++++++++ .../network/soup/ResourceHandleSoup.cpp | 10 ++++---- 6 files changed, 53 insertions(+), 9 deletions(-) diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog index a908c113568..1d189e9264b 100644 --- a/LayoutTests/ChangeLog +++ b/LayoutTests/ChangeLog @@ -1,3 +1,24 @@ +2013-08-28 Sergio Villar Senin + + [Soup] WebTiming information not shown in the inspector + https://bugs.webkit.org/show_bug.cgi?id=118395 + + Reviewed by Martin Robinson. + + Fixed the webiming-ssl.php test that was incorrectly considering a + FAIL as the expected result. It was probably just a legacy + decision which came from the times where DRT was responsible of + reporting WebTiming information. + + Also added a new test that fails due to wkb.ug/103927. It was not + detected before because there were no timing information in the + response. + + * http/tests/misc/resources/webtiming-ssl.html: + * http/tests/misc/webtiming-ssl-expected.txt: + * platform/gtk/TestExpectations: added + http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html. + 2013-08-28 Gabor Rapcsanyi Unreviewed ARM Qt gardening. diff --git a/LayoutTests/http/tests/misc/resources/webtiming-ssl.html b/LayoutTests/http/tests/misc/resources/webtiming-ssl.html index 5848e2f0fec..d9607934be6 100644 --- a/LayoutTests/http/tests/misc/resources/webtiming-ssl.html +++ b/LayoutTests/http/tests/misc/resources/webtiming-ssl.html @@ -9,7 +9,7 @@