Commit 8e3f8bda authored by mitz@apple.com's avatar mitz@apple.com

WebCore:

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17555
          <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page

        Test: fast/dynamic/subtree-table-cell-height.html

        * rendering/RenderObject.cpp:
        (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their
        height depends on their contents even if the CSS height property is
        fixed.

LayoutTests:

        Reviewed by Darin Adler.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17555
          <rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page

        * fast/dynamic/subtree-table-cell-height.html: Added.
        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
        * platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 6997a5d3
2008-02-26 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=17555
<rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
* fast/dynamic/subtree-table-cell-height.html: Added.
* platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
* platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
* platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
2008-02-26 Satoshi Nakagawa <artension@gmail.com>
Reviewed by Darin. Tweaked and landed by Alexey.
<div style="display: table-cell; vertical-align: bottom; width: 100px; height: 100px; overflow: hidden; background-color: red;">
<div id="target" style="width: 100px; height: 50px; background-color: green;"></div>
</div>
<script>
if (window.layoutTestController)
layoutTestController.waitUntilDone();
setTimeout(function()
{
document.getElementById("target").style.height = "100px";
if (window.layoutTestController)
layoutTestController.notifyDone();
},
0);
</script>
18f1f64eab31dfb69467a497de9442d7
\ No newline at end of file
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x584
RenderTable at (0,0) size 100x100
RenderTableSection (anonymous) at (0,0) size 100x100
RenderTableRow (anonymous) at (0,0) size 100x100
layer at (8,8) size 100x100
RenderTableCell {DIV} at (0,0) size 100x100 [bgcolor=#FF0000] [r=0 c=0 rs=1 cs=1]
RenderBlock {DIV} at (0,0) size 100x100 [bgcolor=#008000]
2008-02-26 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=17555
<rdar://problem/5766016> REGRESSION (r27351): Thumbnails positioned wrong on Getty Images results page
Test: fast/dynamic/subtree-table-cell-height.html
* rendering/RenderObject.cpp:
(WebCore::objectIsRelayoutBoundary): Exclude table cells, since their
height depends on their contents even if the CSS height property is
fixed.
2008-02-25 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
......@@ -710,9 +710,11 @@ void RenderObject::setChildNeedsLayout(bool b, bool markParents)
static inline bool objectIsRelayoutBoundary(const RenderObject *obj)
{
// FIXME: In future it may be possible to broaden this condition in order to improve performance
// FIXME: In future it may be possible to broaden this condition in order to improve performance.
// Table cells are excluded because even when their CSS height is fixed, their height()
// may depend on their contents.
return obj->isTextField() || obj->isTextArea()
|| obj->hasOverflowClip() && !obj->style()->width().isIntrinsicOrAuto() && !obj->style()->height().isIntrinsicOrAuto() && !obj->style()->height().isPercent()
|| obj->hasOverflowClip() && !obj->style()->width().isIntrinsicOrAuto() && !obj->style()->height().isIntrinsicOrAuto() && !obj->style()->height().isPercent() && !obj->isTableCell()
#if ENABLE(SVG)
|| obj->isSVGRoot()
#endif
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment