Commit 8e07cd4f authored by mario@webkit.org's avatar mario@webkit.org

2010-12-10 Mario Sanchez Prada <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] AX: implement isEnabled in DRT
        https://bugs.webkit.org/show_bug.cgi?id=50814

        Unskip passing accessibility/aria-disabled.html test.

        * platform/gtk/Skipped: Unskip test.
2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] AX: implement isEnabled in DRT
        https://bugs.webkit.org/show_bug.cgi?id=50814

        Implement AccessibilityUIElement::isEnabled() for GTK.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (checkElementState): New function to refactor common code.
        (AccessibilityUIElement::isEnabled): Implement this by checking
        the current state of the AtkObject.
        (AccessibilityUIElement::isSelected): Use the new
        checkElementState function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@73732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 3aaada28
2010-12-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] AX: implement isEnabled in DRT
https://bugs.webkit.org/show_bug.cgi?id=50814
Unskip passing accessibility/aria-disabled.html test.
* platform/gtk/Skipped: Unskip test.
2010-12-10 Csaba Osztrogonác <ossy@webkit.org>
Unreviewed. Remove platform specific expected files after r73720.
......
......@@ -56,7 +56,6 @@ http/tests/incremental/split-hex-entities.pl
# An implementation of accessibilityController is required.
# Tests failing
accessibility/aria-combobox.html
accessibility/aria-disabled.html
accessibility/ellipsis-text.html
accessibility/aria-help.html
accessibility/aria-hidden.html
......
2010-12-10 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[GTK] AX: implement isEnabled in DRT
https://bugs.webkit.org/show_bug.cgi?id=50814
Implement AccessibilityUIElement::isEnabled() for GTK.
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(checkElementState): New function to refactor common code.
(AccessibilityUIElement::isEnabled): Implement this by checking
the current state of the AtkObject.
(AccessibilityUIElement::isSelected): Use the new
checkElementState function.
2010-12-10 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
......
......@@ -371,12 +371,19 @@ JSStringRef AccessibilityUIElement::valueDescription()
return JSStringCreateWithCharacters(0, 0);
}
bool AccessibilityUIElement::isEnabled()
static bool checkElementState(PlatformUIElement element, AtkStateType stateType)
{
// FIXME: implement
return false;
if (!ATK_IS_OBJECT(element))
return false;
PlatformRefPtr<AtkStateSet> stateSet = adoptPlatformRef(atk_object_ref_state_set(ATK_OBJECT(element)));
return atk_state_set_contains_state(stateSet.get(), stateType);
}
bool AccessibilityUIElement::isEnabled()
{
return checkElementState(m_element, ATK_STATE_ENABLED);
}
int AccessibilityUIElement::insertionPointLineNumber()
{
......@@ -398,13 +405,7 @@ bool AccessibilityUIElement::isRequired() const
bool AccessibilityUIElement::isSelected() const
{
if (!ATK_IS_OBJECT(m_element))
return false;
PlatformRefPtr<AtkStateSet> stateSet = adoptPlatformRef(atk_object_ref_state_set(ATK_OBJECT(m_element)));
gboolean isSelected = atk_state_set_contains_state(stateSet.get(), ATK_STATE_SELECTED);
return isSelected;
return checkElementState(m_element, ATK_STATE_SELECTED);
}
int AccessibilityUIElement::hierarchicalLevel() const
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment