Commit 8d37900d authored by tommyw@google.com's avatar tommyw@google.com
Browse files

MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback

https://bugs.webkit.org/show_bug.cgi?id=97456

Reviewed by Adam Barth.

Renamed onnegotationneeded to onnegotiationneeded.

Source/WebCore:

Existing test updated.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::negotiationNeeded):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* dom/EventNames.h:
(WebCore):

LayoutTests:

* fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent c42c420b
2012-09-24 Tommy Widenflycht <tommyw@google.com>
MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
https://bugs.webkit.org/show_bug.cgi?id=97456
Reviewed by Adam Barth.
Renamed onnegotationneeded to onnegotiationneeded.
* fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
* fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
2012-09-24 Dominik Röttsches <dominik.rottsches@intel.com>
 
[EFL][DRT] Enable Regions support
......@@ -4,7 +4,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
PASS Got a stream.
PASS onNegotationNeeded was called.
PASS onNegotiationNeeded was called.
PASS successfullyParsed is true
TEST COMPLETE
......
......@@ -24,8 +24,8 @@ function getUserMedia(dictionary, callback) {
}
}
function onNegotationNeeded(event) {
testPassed('onNegotationNeeded was called.');
function onNegotiationNeeded(event) {
testPassed('onNegotiationNeeded was called.');
finishJSTest();
}
......@@ -35,7 +35,7 @@ function gotStream(s) {
stream = s;
pc = new webkitRTCPeerConnection(null, null);
pc.onnegotationneeded = onNegotationNeeded;
pc.onnegotiationneeded = onNegotiationNeeded;
pc.addStream(stream);
}
......
2012-09-24 Tommy Widenflycht <tommyw@google.com>
MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback
https://bugs.webkit.org/show_bug.cgi?id=97456
Reviewed by Adam Barth.
Renamed onnegotationneeded to onnegotiationneeded.
Existing test updated.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::negotiationNeeded):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* dom/EventNames.h:
(WebCore):
2012-09-24 Peter Beverloo <peter@chromium.org>
 
Android's mock scrollbars shows up as a difference in layout test results
......@@ -393,7 +393,7 @@ void RTCPeerConnection::close(ExceptionCode& ec)
void RTCPeerConnection::negotiationNeeded()
{
dispatchEvent(Event::create(eventNames().negotationneededEvent, false, false));
dispatchEvent(Event::create(eventNames().negotiationneededEvent, false, false));
}
void RTCPeerConnection::didGenerateIceCandidate(PassRefPtr<RTCIceCandidateDescriptor> iceCandidateDescriptor)
......
......@@ -86,7 +86,7 @@ public:
void close(ExceptionCode&);
DEFINE_ATTRIBUTE_EVENT_LISTENER(negotationneeded);
DEFINE_ATTRIBUTE_EVENT_LISTENER(negotiationneeded);
DEFINE_ATTRIBUTE_EVENT_LISTENER(icecandidate);
DEFINE_ATTRIBUTE_EVENT_LISTENER(open);
DEFINE_ATTRIBUTE_EVENT_LISTENER(statechange);
......
......@@ -75,7 +75,7 @@ module mediastream {
void close()
raises(DOMException);
attribute EventListener onnegotationneeded;
attribute EventListener onnegotiationneeded;
attribute EventListener onicecandidate;
attribute EventListener onopen;
attribute EventListener onstatechange;
......
......@@ -229,7 +229,7 @@ namespace WebCore {
macro(unmute) \
macro(icechange) \
macro(icecandidate) \
macro(negotationneeded) \
macro(negotiationneeded) \
\
macro(show) \
\
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment