Commit 8cc11e6d authored by rwlbuis@webkit.org's avatar rwlbuis@webkit.org

2011-01-27 Rob Buis <rwlbuis@gmail.com>

        Reviewed by Kent Tamura.

        Color changes to option elements in a select multiple aren't drawn immediately
        https://bugs.webkit.org/show_bug.cgi?id=49790

        Redirect style changes on <option> element to the owner <select> element.

        Test: fast/repaint/select-option-background-color.html

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setRenderStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 118a71a1
2011-01-27 Rob Buis <rwlbuis@gmail.com>
Reviewed by Kent Tamura.
Add test for:
Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790
* fast/repaint/select-option-background-color.html: Added.
* platform/mac/fast/repaint/select-option-background-color-expected.checksum: Added.
* platform/mac/fast/repaint/select-option-background-color-expected.png: Added.
* platform/mac/fast/repaint/select-option-background-color-expected.txt: Added.
2011-01-27 David Grogan <dgrogan@google.com>
Reviewed by Jeremy Orlow.
<head>
<title>This is a test for regression against https://bugs.webkit.org/show_bug.cgi?id=49790</title>
</head>
<body style="margin: 0;" onload="runRepaintTest()">
<script>
function repaintTest()
{
document.getElementById('option').style.backgroundColor = 'green';
}
</script>
<script src="resources/repaint.js"></script>
<p>This is a test for regression against <a href="https://bugs.webkit.org/show_bug.cgi?id=49790">https://bugs.webkit.org/show_bug.cgi?id=49790</a></p>
<select multiple="multiple">
<option id="option" value="A">A</option>
<option id="option" value="B">B</option>
</select>
</body>
29bae32726dbba8b202adb59b33e7947
\ No newline at end of file
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (0,0) size 800x600
RenderBlock {P} at (0,0) size 800x18
RenderText {#text} at (0,0) size 220x18
text run at (0,0) width 220: "This is a test for regression against "
RenderInline {A} at (0,0) size 305x18 [color=#0000EE]
RenderText {#text} at (220,0) size 305x18
text run at (220,0) width 305: "https://bugs.webkit.org/show_bug.cgi?id=49790"
RenderBlock (anonymous) at (0,34) size 800x61
RenderListBox {SELECT} at (2,2) size 25x57 [bgcolor=#FFFFFF] [border: (1px inset #808080)]
RenderText {#text} at (0,0) size 0x0
2011-01-27 Rob Buis <rwlbuis@gmail.com>
Reviewed by Kent Tamura.
Color changes to option elements in a select multiple aren't drawn immediately
https://bugs.webkit.org/show_bug.cgi?id=49790
Redirect style changes on <option> element to the owner <select> element.
Test: fast/repaint/select-option-background-color.html
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::setRenderStyle):
2011-01-19 Stephen White <senorblanco@chromium.org>
Reviewed by Darin Adler.
......@@ -221,6 +221,9 @@ String HTMLOptionElement::label() const
void HTMLOptionElement::setRenderStyle(PassRefPtr<RenderStyle> newStyle)
{
m_style = newStyle;
if (HTMLSelectElement* select = ownerSelectElement())
if (RenderObject* renderer = select->renderer())
renderer->repaint();
}
RenderStyle* HTMLOptionElement::nonRendererRenderStyle() const
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment