Commit 8bfe97c6 authored by akling@apple.com's avatar akling@apple.com
Browse files

REGRESSION(r154219): 30% more malloc memory used on html5-full-render.

<https://webkit.org/b/122034>

Reviewed by Antti Koivisto.

canExecuteScripts() used to rely on Frame::settings() returning null
when the Frame was disconnected from its Page, and giving Frame its
own handle on the Settings broke this mechanism.

This caused us to hold on for some objects for a bit longer than we
needed to in the run-perf-tests harness, showing up as a massive 30%
regression in malloc memory use.

Fixed it by added an explicit null check of Frame::page().


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent e1499256
2013-09-27 Andreas Kling <akling@apple.com>
REGRESSION(r154219): 30% more malloc memory used on html5-full-render.
<https://webkit.org/b/122034>
Reviewed by Antti Koivisto.
canExecuteScripts() used to rely on Frame::settings() returning null
when the Frame was disconnected from its Page, and giving Frame its
own handle on the Settings broke this mechanism.
This caused us to hold on for some objects for a bit longer than we
needed to in the run-perf-tests harness, showing up as a massive 30%
regression in malloc memory use.
Fixed it by added an explicit null check of Frame::page().
2013-09-27 Alexey Proskuryakov <ap@apple.com>
 
Updating bindings test results after KURL->URL rename.
......@@ -51,6 +51,9 @@ bool ScriptController::canExecuteScripts(ReasonForCallingCanExecuteScripts reaso
return true;
}
if (!m_frame.page())
return false;
const bool allowed = m_frame.loader().client().allowScript(m_frame.settings().isScriptEnabled());
if (!allowed && reason == AboutToExecuteScript)
m_frame.loader().client().didNotAllowScript();
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment