Commit 88dc607b authored by jer.noble@apple.com's avatar jer.noble@apple.com
Browse files

REGRESSION (r150516): Media controls are messed up on right-to-left webpages

https://bugs.webkit.org/show_bug.cgi?id=120234

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/video-rtl.html

Make the media control panel explicitly direction:ltr. The captions menu and captions
display are unaffected, so rtl content will continue to appear rtl there.

* css/mediaControls.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

LayoutTests:

* media/video-rtl-expected.html: Added.
* media/video-rtl.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent a1231c3e
2013-08-23 Jer Noble <jer.noble@apple.com>
REGRESSION (r150516): Media controls are messed up on right-to-left webpages
https://bugs.webkit.org/show_bug.cgi?id=120234
Reviewed by Dan Bernstein.
* media/video-rtl-expected.html: Added.
* media/video-rtl.html: Added.
2013-08-23 Eric Carlson <eric.carlson@apple.com>
 
[Mac] some track language tags are not recognized
<html>
<head>
<script src=media-file.js></script>
<script>
var requirePixelDump = true;
function start() {
findMediaElement();
video.src = findMediaFile('audio', 'content/test');
video.addEventListener('canplaythrough', endTest, false);
}
</script>
<script src=video-test.js></script>
</head>
<body onload="start()">
<video controls></video>
</body>
</html>
\ No newline at end of file
<html>
<head>
<script src=media-file.js></script>
<script>
var requirePixelDump = true;
function start() {
findMediaElement();
video.src = findMediaFile('audio', 'content/test');
video.addEventListener('canplaythrough', endTest, false);
}
</script>
<script src=video-test.js></script>
<style>
video { direction: rtl; }
</style>
</head>
<body onload="start()">
<video controls></video>
</body>
</html>
\ No newline at end of file
2013-08-23 Jer Noble <jer.noble@apple.com>
REGRESSION (r150516): Media controls are messed up on right-to-left webpages
https://bugs.webkit.org/show_bug.cgi?id=120234
Reviewed by Dan Bernstein.
Test: media/video-rtl.html
Make the media control panel explicitly direction:ltr. The captions menu and captions
display are unaffected, so rtl content will continue to appear rtl there.
* css/mediaControls.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
2013-08-23 Beth Dakin <bdakin@apple.com>
 
REGRESSION (r132545): Some PDFs generated by WebKit are blank when viewed in
......@@ -45,6 +45,7 @@ audio {
audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
display: -webkit-flex;
direction: ltr;
-webkit-flex-direction: row;
-webkit-align-items: center;
-webkit-user-select: none;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment