Commit 88c795d7 authored by bdakin's avatar bdakin

Reviewed by Brady.

        Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text 
        blinks when mouse is moved, and is invisible otherwise

        -and-

        <rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround 
        methodology

        The fix for the first bug is to compare against the bundle 
        identifiers for Adobe Reader and the non-Pro Adobe Acrobat in 
        addition to Adobe Acrobat Pro. The fix for the second bug is to 
        check the version number of Acrobat/Reader through 
        WebKitSystemInterface instead of checking which version of WebKit 
        it has been linked against.

        * English.lproj/StringsNotToBeLocalized.txt: Two new bundle 
        identifiers.
        * Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b7701503
2007-03-29 Beth Dakin <bdakin@apple.com>
Reviewed by Brady.
Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text
blinks when mouse is moved, and is invisible otherwise
-and-
<rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround
methodology
The fix for the first bug is to compare against the bundle
identifiers for Adobe Reader and the non-Pro Adobe Acrobat in
addition to Adobe Acrobat Pro. The fix for the second bug is to
check the version number of Acrobat/Reader through
WebKitSystemInterface instead of checking which version of WebKit
it has been linked against.
* English.lproj/StringsNotToBeLocalized.txt: Two new bundle
identifiers.
* Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
* WebView/WebView.mm:
(-[WebView _updateWebCoreSettingsFromPreferences:]):
2007-03-29 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Beth Dakin.
......
......@@ -306,7 +306,9 @@
"canGoBack"
"canGoForward"
"com.RealNetworks.RealOne Player"
"com.adobe.Acrobat"
"com.adobe.Acrobat.Pro"
"com.adobe.Reader"
"com.apple.Aperture"
"com.apple.AppKit"
"com.apple.HIWebView"
......
......@@ -32,7 +32,6 @@
A version of -1 is returned if the main executable did not link against WebKit (should never happen). */
#define WEBKIT_FIRST_VERSION_WITH_3_0_CONTEXT_MENU_TAGS 0x020A0000 // 522.0.0
#define WEBKIT_FIRST_VERSION_WITHOUT_ACROBAT_QUIRK 0x020A0000 // 522.0.0
#define WEBKIT_FIRST_VERSION_WITH_LOCAL_RESOURCE_SECURITY_RESTRICTION 0x020A0000 // 522.0.0
#define WEBKIT_FIRST_VERSION_WITHOUT_APERTURE_QUIRK 0x020A0000 // 522.0.0
#define WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK 0x020A0000 // 522.0.0
......
......@@ -860,8 +860,9 @@ static bool debugWidget = true;
settings->setUserStyleSheetLocation([NSURL URLWithString:(location ? location : @"")]);
} else
settings->setUserStyleSheetLocation([NSURL URLWithString:@""]);
settings->setNeedsAcrobatFrameReloadingQuirk(!WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITHOUT_ACROBAT_QUIRK)
&& [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@"com.adobe.Acrobat.Pro"]);
settings->setNeedsAcrobatFrameReloadingQuirk(WKAppVersionCheckLessThan(@"com.adobe.Acrobat", -1, 9)
|| WKAppVersionCheckLessThan(@"com.adobe.Acrobat.Pro", -1, 9)
|| WKAppVersionCheckLessThan(@"com.adobe.Reader", -1, 9));
}
- (void)_preferencesChangedNotification: (NSNotification *)notification
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment