Commit 871b3544 authored by csaavedra@igalia.com's avatar csaavedra@igalia.com

Rename Editing tests whose expectations are Mac specific

https://bugs.webkit.org/show_bug.cgi?id=113414

Reviewed by Ryosuke Niwa.

These tests have expectations that assume that word selection
works always as in Mac and therefore will break when ran with
editingBehavior set, for instance, to Windows (see bug
110487). Rename them to have the suffix -mac and explicitly set
editingBehavior to Mac.

When the fix for 110487 lands, counterparts to these tests with
suffix -win, editingBehavior set to win, and updated expectations
will be added.

* editing/deleting/smart-editing-disabled-mac-expected.txt:
Renamed from
LayoutTests/editing/deleting/smart-editing-disabled-expected.txt.
* editing/deleting/smart-editing-disabled-mac.html: Renamed from
LayoutTests/editing/deleting/smart-editing-disabled.html.
* editing/execCommand/remove-format-multiple-elements-mac-expected.txt:
Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements-expected.txt.
* editing/execCommand/remove-format-multiple-elements-mac.html:
Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements.html.
* editing/execCommand/script-tests/remove-format-multiple-elements-mac.js:
Renamed from
LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements.js.
* editing/execCommand/script-tests/toggle-link-mac.js: Renamed
from LayoutTests/editing/execCommand/script-tests/toggle-link.js.
* editing/execCommand/toggle-link-mac-expected.txt: Renamed from
LayoutTests/editing/execCommand/toggle-link-expected.txt.
* editing/execCommand/toggle-link-mac.html: Renamed from
LayoutTests/editing/execCommand/toggle-link.html.
* editing/style/make-text-writing-direction-inline-mac-expected.txt:
Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline-expected.txt.
* editing/style/make-text-writing-direction-inline-mac.html:
Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline.html.
* editing/style/push-down-font-styles-mac-expected.txt: Renamed
from LayoutTests/editing/style/push-down-font-styles-expected.txt.
* editing/style/push-down-font-styles-mac.html: Renamed from
LayoutTests/editing/style/push-down-implicit-styles.html.
* editing/style/push-down-implicit-styles-around-list-mac-expected.txt:
Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list-expected.txt.
* editing/style/push-down-implicit-styles-around-list-mac.html:
Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list.html.
* editing/style/push-down-implicit-styles-mac-expected.txt:
Renamed from
LayoutTests/editing/style/push-down-implicit-styles-expected.txt.
* editing/style/push-down-implicit-styles-mac.html: Renamed from
LayoutTests/editing/style/push-down-font-styles.html.
* editing/style/script-tests/make-text-writing-direction-inline-mac.js:
Renamed from
LayoutTests/editing/style/script-tests/make-text-writing-direction-inline.js.
* editing/style/script-tests/push-down-font-styles-mac.js: Renamed
from
LayoutTests/editing/style/script-tests/push-down-font-styles.js.
* editing/style/script-tests/push-down-implicit-styles-around-list-mac.js:
Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list.js.
* editing/style/script-tests/push-down-implicit-styles-mac.js:
Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles.js.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 27d6ce71
2013-03-27 Claudio Saavedra <csaavedra@igalia.com>
Rename Editing tests whose expectations are Mac specific
https://bugs.webkit.org/show_bug.cgi?id=113414
Reviewed by Ryosuke Niwa.
These tests have expectations that assume that word selection
works always as in Mac and therefore will break when ran with
editingBehavior set, for instance, to Windows (see bug
110487). Rename them to have the suffix -mac and explicitly set
editingBehavior to Mac.
When the fix for 110487 lands, counterparts to these tests with
suffix -win, editingBehavior set to win, and updated expectations
will be added.
* editing/deleting/smart-editing-disabled-mac-expected.txt:
Renamed from
LayoutTests/editing/deleting/smart-editing-disabled-expected.txt.
* editing/deleting/smart-editing-disabled-mac.html: Renamed from
LayoutTests/editing/deleting/smart-editing-disabled.html.
* editing/execCommand/remove-format-multiple-elements-mac-expected.txt:
Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements-expected.txt.
* editing/execCommand/remove-format-multiple-elements-mac.html:
Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements.html.
* editing/execCommand/script-tests/remove-format-multiple-elements-mac.js:
Renamed from
LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements.js.
* editing/execCommand/script-tests/toggle-link-mac.js: Renamed
from LayoutTests/editing/execCommand/script-tests/toggle-link.js.
* editing/execCommand/toggle-link-mac-expected.txt: Renamed from
LayoutTests/editing/execCommand/toggle-link-expected.txt.
* editing/execCommand/toggle-link-mac.html: Renamed from
LayoutTests/editing/execCommand/toggle-link.html.
* editing/style/make-text-writing-direction-inline-mac-expected.txt:
Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline-expected.txt.
* editing/style/make-text-writing-direction-inline-mac.html:
Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline.html.
* editing/style/push-down-font-styles-mac-expected.txt: Renamed
from LayoutTests/editing/style/push-down-font-styles-expected.txt.
* editing/style/push-down-font-styles-mac.html: Renamed from
LayoutTests/editing/style/push-down-implicit-styles.html.
* editing/style/push-down-implicit-styles-around-list-mac-expected.txt:
Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list-expected.txt.
* editing/style/push-down-implicit-styles-around-list-mac.html:
Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list.html.
* editing/style/push-down-implicit-styles-mac-expected.txt:
Renamed from
LayoutTests/editing/style/push-down-implicit-styles-expected.txt.
* editing/style/push-down-implicit-styles-mac.html: Renamed from
LayoutTests/editing/style/push-down-font-styles.html.
* editing/style/script-tests/make-text-writing-direction-inline-mac.js:
Renamed from
LayoutTests/editing/style/script-tests/make-text-writing-direction-inline.js.
* editing/style/script-tests/push-down-font-styles-mac.js: Renamed
from
LayoutTests/editing/style/script-tests/push-down-font-styles.js.
* editing/style/script-tests/push-down-implicit-styles-around-list-mac.js:
Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list.js.
* editing/style/script-tests/push-down-implicit-styles-mac.js:
Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles.js.
2013-03-27 Yongjun Zhang <yongjun_zhang@apple.com>
Add a settings to disallow initializing background-size if background shorthand doesn't include it.
......@@ -7,6 +7,8 @@ if (window.testRunner) {
internals.settings.setSmartInsertDeleteEnabled(false);
internals.settings.setSelectTrailingWhitespaceEnabled(true);
}
if (window.internals)
internals.settings.setEditingBehavior('mac');
function editingTest() {
var div = document.getElementById("div");
......
......@@ -6,7 +6,7 @@
<body>
<p id="description"></p>
<div id="console"></div>
<script src="script-tests/remove-format-multiple-elements.js"></script>
<script src="script-tests/remove-format-multiple-elements-mac.js"></script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
......@@ -3,6 +3,8 @@ description("This tests removing multiple elements by RemoveFormat command.")
var testContainer = document.createElement("div");
testContainer.contentEditable = true;
document.body.appendChild(testContainer);
if (window.internals)
internals.settings.setEditingBehavior("mac");
function testRemoveFormat(initialContents, selector, expected)
{
......
......@@ -3,6 +3,8 @@ description("Test to make sure we remove span tags with no attributes if we remo
var testContainer = document.createElement("div");
testContainer.contentEditable = true;
document.body.appendChild(testContainer);
if (window.internals)
internals.settings.setEditingBehavior('mac');
function testSingleToggle(toggleCommand, initialContents, selector, expectedContents)
{
......
......@@ -6,7 +6,7 @@
<body>
<p id="description"></p>
<div id="console"></div>
<script src="script-tests/toggle-link.js"></script>
<script src="script-tests/toggle-link-mac.js"></script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
......@@ -7,7 +7,7 @@
<body>
<p id="description"></p>
<div id="console"></div>
<script src="script-tests/make-text-writing-direction-inline.js"></script>
<script src="script-tests/make-text-writing-direction-inline-mac.js"></script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
......@@ -6,7 +6,7 @@
<body>
<p id="description"></p>
<div id="console"></div>
<script src="script-tests/push-down-implicit-styles.js"></script>
<script src="script-tests/push-down-font-styles-mac.js"></script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
......@@ -6,7 +6,7 @@
<body>
<p id="description"></p>
<div id="console"></div>
<script src="script-tests/push-down-implicit-styles-around-list.js"></script>
<script src="script-tests/push-down-implicit-styles-around-list-mac.js"></script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
......@@ -6,7 +6,7 @@
<body>
<p id="description"></p>
<div id="console"></div>
<script src="script-tests/push-down-font-styles.js"></script>
<script src="script-tests/push-down-implicit-styles-mac.js"></script>
<script src="../../fast/js/resources/js-test-post.js"></script>
</body>
</html>
description('Tests to ensure MakeTextWritingDirection* modifies the direction of text and embed texts properly.');
if (window.internals)
internals.settings.setEditingBehavior('mac');
if (!window.testRunner)
testFailed('This test requires testRunner');
......
description('Test to make sure we push down inline styles properly.');
if (window.internals)
internals.settings.setEditingBehavior('mac');
var testContainer = document.createElement("div");
testContainer.contentEditable = true;
document.body.appendChild(testContainer);
......
description('Test to make sure we push down inline styles properly.');
if (window.internals)
internals.settings.setEditingBehavior('mac');
var testContainer = document.createElement("div");
testContainer.contentEditable = true;
document.body.appendChild(testContainer);
......
description('Test to make sure we push down inline styles properly.');
if (window.internals)
internals.settings.setEditingBehavior('mac');
var testContainer = document.createElement("div");
testContainer.contentEditable = true;
document.body.appendChild(testContainer);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment