Commit 82d5b0f9 authored by timothy@apple.com's avatar timothy@apple.com
Browse files

Fixes a crash when scrolling a frame that goes away mid-scroll.

<rdar://problem/7400263>

Reviewed by John Sullivan.

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]): Retain self incase the last
reference is released when calling super.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent aab13661
2009-12-02 Timothy Hatcher <timothy@apple.com>
Fixes a crash when scrolling a frame that goes away mid-scroll.
<rdar://problem/7400263>
Reviewed by John Sullivan.
* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView scrollWheel:]): Retain self incase the last
reference is released when calling super.
2009-11-13 Timothy Hatcher <timothy@apple.com>
 
Migrate DOMHTMLInputElementPrivate.h as a private header.
......
......@@ -354,6 +354,10 @@ static const unsigned cMaxUpdateScrollbarsPass = 2;
}
}
// Calling super can release the last reference. <rdar://problem/7400263>
// Hold a reference so the code following the super call will not crash.
[self retain];
[super scrollWheel:event];
if (!isLatchingEvent) {
......@@ -363,6 +367,8 @@ static const unsigned cMaxUpdateScrollbarsPass = 2;
verticallyPinnedByPreviousWheelEvent = (verticalPosition == 0.0 || verticalPosition == 1.0);
horizontallyPinnedByPreviousWheelEvent = (horizontalPosition == 0.0 || horizontalPosition == 1.0);
}
[self release];
}
- (BOOL)accessibilityIsIgnored
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment