Commit 82857b28 authored by reni@webkit.org's avatar reni@webkit.org
Browse files

ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement

https://bugs.webkit.org/show_bug.cgi?id=119672

Reviewed by Darin Adler.

Source/WebCore:

The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set
to default 0. This way we have to check its existence before the usage.

Test: editing/execCommand/extracted_style_assert.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):

LayoutTests:

Test with NULL extractedStyle.

* editing/execCommand/extracted_style_assert-expected.txt: Added.
* editing/execCommand/extracted_style_assert.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent f55039c5
2013-08-22 Renata Hodovan <reni@webkit.org>
ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement
https://bugs.webkit.org/show_bug.cgi?id=119672
Reviewed by Darin Adler.
Test with NULL extractedStyle.
* editing/execCommand/extracted_style_assert-expected.txt: Added.
* editing/execCommand/extracted_style_assert.html: Added.
2013-08-08 Sergio Villar Senin <svillar@igalia.com>
 
[CSS Grid Layout] Refactor testing code
<html>
<body>
<table>
<td>
<a></a>
</td>
</table>
<script>
if (window.testRunner)
testRunner.dumpAsText();
document.designMode = "on";
document.execCommand("SelectAll");
document.execCommand("CreateLink", 0, 'foo');
document.body.innerHTML = "PASS. WebKit didn't crash.";
</script>
</body>
</html>
2013-08-22 Renata Hodovan <reni@webkit.org>
ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement
https://bugs.webkit.org/show_bug.cgi?id=119672
Reviewed by Darin Adler.
The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set
to default 0. This way we have to check its existence before the usage.
Test: editing/execCommand/extracted_style_assert.html
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
2013-08-21 Commit Queue <commit-queue@webkit.org>
 
Unreviewed, rolling out r154416.
......@@ -887,8 +887,8 @@ bool ApplyStyleCommand::removeInlineStyleFromElement(EditingStyle* style, PassRe
if (isStyledInlineElementToRemove(element.get())) {
if (mode == RemoveNone)
return true;
ASSERT(extractedStyle);
extractedStyle->mergeInlineStyleOfElement(element.get(), EditingStyle::OverrideValues);
if (extractedStyle)
extractedStyle->mergeInlineStyleOfElement(element.get(), EditingStyle::OverrideValues);
removeNodePreservingChildren(element);
return true;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment