Commit 82447ad9 authored by darin's avatar darin

LayoutTests:

        Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5656
        REGRESSION: Buttons on Yahoo! Mail misplaced in ToT
        <rdar://problem/4404335>
        Tests whether white-space mode on buttons is inherited and not forced.

        * fast/forms/button-white-space-expected.checksum: Added.
        * fast/forms/button-white-space-expected.png: Added.
        * fast/forms/button-white-space-expected.txt: Added.
        * fast/forms/button-white-space.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5656
        REGRESSION: Buttons on Yahoo! Mail misplaced in ToT
        <rdar://problem/4404335>
        Tests whether white-space mode on buttons is inheritied and not forced.
        Originally broken in Subversion revision r10909.

        * css/html4.css: Remove default white-space value for <button> tag to
        allow it to be inherited.
        * rendering/render_theme_mac.mm:
        (khtml::RenderThemeMac::adjustButtonStyle): Fix misleading comment.

        * css/UserAgentStyleSheets.cpp: Touched this file to make the rebuild
        of html4.css work (shouldn't have to do this).



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12294 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 67322639
2006-01-22 David Kilzer <ddkilzer@kilzer.net>
Reviewed by Maciej.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5656
REGRESSION: Buttons on Yahoo! Mail misplaced in ToT
<rdar://problem/4404335>
Tests whether white-space mode on buttons is inherited and not forced.
* fast/forms/button-white-space-expected.checksum: Added.
* fast/forms/button-white-space-expected.png: Added.
* fast/forms/button-white-space-expected.txt: Added.
* fast/forms/button-white-space.html: Added.
2006-01-22 Eric Seidel <eseidel@apple.com>
Reviewed by darin.
......
83768a1ace43085d3af813e2895a45b3
\ No newline at end of file
layer at (0,0) size 800x600
RenderCanvas at (0,0) size 800x600
layer at (0,0) size 800x600
RenderBlock {HTML} at (0,0) size 800x600
RenderBody {BODY} at (8,8) size 784x579
RenderBlock {P} at (0,0) size 784x36
RenderInline {A} at (0,0) size 63x18 [color=#0000EE]
RenderText {TEXT} at (0,0) size 63x18
text run at (0,0) width 63: "Bug 5656"
RenderText {TEXT} at (63,0) size 765x36
text run at (63,0) width 702: " tests whether buttons force a white-space mode or not. These tests will only pass if the white-space mode is not"
text run at (0,18) width 169: "forced and if it is inherited."
RenderBlock {DIV} at (0,52) size 784x18
RenderText {TEXT} at (0,0) size 358x18
text run at (0,0) width 358: "Buttons should appear next to each other in a single row:"
RenderTable {TABLE} at (0,70) size 194x28
RenderTableSection {TBODY} at (0,0) size 0x28
RenderTableRow {TR} at (0,0) size 0x0
RenderTableCell {TD} at (2,2) size 190x24 [r=0 c=0 rs=1 cs=1]
RenderButton {BUTTON} at (3,3) size 77x18 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0) none (2px outset #C0C0C0)]
RenderBlock (anonymous) at (8,2) size 61x13
RenderText {TEXT} at (0,0) size 61x13
text run at (0,0) width 61: "Search Mail"
RenderText {TEXT} at (82,2) size 4x18
text run at (82,2) width 4: " "
RenderButton {BUTTON} at (88,3) size 99x18 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0) none (2px outset #C0C0C0)]
RenderBlock (anonymous) at (8,2) size 83x13
RenderText {TEXT} at (0,0) size 83x13
text run at (0,0) width 83: "Search the Web"
RenderText {TEXT} at (0,0) size 0x0
RenderBlock {DIV} at (0,98) size 784x18
RenderText {TEXT} at (0,0) size 188x18
text run at (0,0) width 188: "Buttons should look identical:"
RenderBlock {DIV} at (0,116) size 784x22
RenderButton {BUTTON} at (2,2) size 75x18 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0) none (2px outset #C0C0C0)]
RenderBlock (anonymous) at (8,2) size 59x13
RenderText {TEXT} at (0,0) size 59x13
text run at (0,0) width 59: "test button"
RenderBlock {DIV} at (0,138) size 784x22
RenderButton {BUTTON} at (2,2) size 75x18 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0) none (2px outset #C0C0C0)]
RenderBlock (anonymous) at (8,2) size 59x13
RenderText {TEXT} at (0,0) size 59x13
text run at (0,0) width 23: "test "
text run at (23,0) width 36: "button"
RenderBlock {DIV} at (0,160) size 784x18
RenderText {TEXT} at (0,0) size 344x18
text run at (0,0) width 344: "Buttons should look identical (ignore vertical spacing):"
RenderBlock {DIV} at (0,178) size 784x22
RenderButton {BUTTON} at (2,2) size 90x18 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0) none (2px outset #C0C0C0)]
RenderBlock (anonymous) at (8,2) size 74x13
RenderText {TEXT} at (0,0) size 74x13
text run at (0,0) width 74: " test button "
RenderBlock {DIV} at (0,200) size 784x22
RenderButton {BUTTON} at (2,2) size 90x18 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0) none (2px outset #C0C0C0)]
RenderBlock (anonymous) at (8,2) size 74x13
RenderText {TEXT} at (0,0) size 74x13
text run at (0,0) width 74: " test button "
RenderBlock {DIV} at (0,235) size 784x22
RenderBlock {PRE} at (0,0) size 784x22
RenderButton {BUTTON} at (2,2) size 90x18 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0) none (2px outset #C0C0C0)]
RenderBlock (anonymous) at (8,2) size 74x13
RenderText {TEXT} at (0,0) size 74x13
text run at (0,0) width 74: " test button "
<p><a href="http://bugzilla.opendarwin.org/show_bug.cgi?id=5656">Bug 5656</a>
tests whether buttons force a white-space mode or not.
These tests will only pass if the white-space mode is not forced and if it is inherited.</p>
<div>Buttons should appear next to each other in a single row:</div>
<table>
<td nowrap>
<button value="Search Mail">Search Mail</button>
<button value="Search the Web" style="white-space:nowrap">Search the Web</button>
</td>
</table>
<div>Buttons should look identical:</div>
<div><button>test button</button></div>
<div><button> test button </button></div>
<div>Buttons should look identical (ignore vertical spacing):</div>
<div><button>&nbsp;&nbsp;test&nbsp;&nbsp;button&nbsp;&nbsp;</button></div>
<div><button style="white-space: pre;"> test button </button></div>
<div><pre><button> test button </button></pre></div>
2006-01-22 David Kilzer <ddkilzer@kilzer.net>
Reviewed by Maciej.
- fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5656
REGRESSION: Buttons on Yahoo! Mail misplaced in ToT
<rdar://problem/4404335>
Tests whether white-space mode on buttons is inheritied and not forced.
Originally broken in Subversion revision r10909.
* css/html4.css: Remove default white-space value for <button> tag to
allow it to be inherited.
* rendering/render_theme_mac.mm:
(khtml::RenderThemeMac::adjustButtonStyle): Fix misleading comment.
* css/UserAgentStyleSheets.cpp: Touched this file to make the rebuild
of html4.css work (shouldn't have to do this).
2006-01-22 Darin Adler <darin@apple.com>
* css/make-css-file-arrays.pl: Fix typo that was resulting in a bunch
......
......@@ -17,4 +17,8 @@
* Boston, MA 02111-1307, USA.
*/
// Added this comment because it doesn't seem to recompile without a change,
// even though the included file is regenerated. We can just tweak this
// comment every time, remove it, reword it, whatever, until we solve the
// Xcode problem.
#include "UserAgentStyleSheetsData.cpp"
......@@ -292,7 +292,6 @@ fieldset {
button {
-khtml-appearance: button;
white-space: normal
}
/* If we add support for CSS2 system fonts, then we won't have to hard code Lucida Grande here. */
......
......@@ -409,7 +409,7 @@ void RenderThemeMac::adjustButtonStyle(CSSStyleSelector* selector, RenderStyle*
// Height is locked to auto.
style->setHeight(Length(Auto));
// White-space is locked to nowrap
// White-space is locked to pre
style->setWhiteSpace(PRE);
// Set the button's vertical size.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment