Commit 819c0246 authored by mkwst@chromium.org's avatar mkwst@chromium.org

Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.

https://bugs.webkit.org/show_bug.cgi?id=107816

Reviewed by Pavel Feldman.

Source/WebCore:

'console.debug' is currently aliased to 'console.log'. Since we now
render debug-level messages differently to log messages, we should use
the proper message level for 'console.debug'.

* page/Console.cpp:
(WebCore::Console::debug):
    Replace the alias to 'console.log' with message creation at
    DebugMessageLevel.

LayoutTests:

* inspector/console/console-tests-expected.txt:
* inspector/extensions/extensions-console-expected.txt:
    Rebaseline this test with the updated message level.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 8c5332d2
2013-01-24 Mike West <mkwst@chromium.org>
Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
https://bugs.webkit.org/show_bug.cgi?id=107816
Reviewed by Pavel Feldman.
* inspector/console/console-tests-expected.txt:
* inspector/extensions/extensions-console-expected.txt:
Rebaseline this test with the updated message level.
2013-01-24 Dima Gorbik <dgorbik@apple.com>
Implement :past pseudo class for the WebVTT ::cue pseudo element
......@@ -22,7 +22,7 @@ CONSOLE MESSAGE: line 31: /regexp.*/
Tests that console logging dumps proper messages.
log console-tests.html:9 console-message console-log-level
debug console-tests.html:10 console-message console-log-level
debug console-tests.html:10 console-message console-debug-level
info console-tests.html:11 console-message console-log-level
warn console-tests.html:12 console-message console-warning-level
error console-tests.html:13 console-message console-error-level
......
......@@ -16,7 +16,7 @@ Started extension.
Running tests...
RUNNING TEST: extension_testAddConsoleMessages
log message extensions-console.html:46 console-message console-log-level
debug message extensions-console.html:47 console-message console-log-level
debug message extensions-console.html:47 console-message console-debug-level
warning message extensions-console.html:48 console-message console-warning-level
error message extensions-console.html:49 console-message console-error-level
log message with two parameters, an integer: 42 and a string: foo extensions-console.html:50 console-message console-log-level
......@@ -35,7 +35,7 @@ RUNNING TEST: extension_testGetConsoleMessages
}
1 : {
line : 47
severity : "log"
severity : "debug"
text : "debug message"
url : .../extensions-console.html
}
......@@ -94,7 +94,7 @@ RUNNING TEST: extension_testOnConsoleMessageAdded
{
0 : {
line : 47
severity : "log"
severity : "debug"
text : "debug message"
url : .../extensions-console.html
}
......
2013-01-24 Mike West <mkwst@chromium.org>
Web Inspector: 'console.debug' should generate messages at DebugMessageLevel.
https://bugs.webkit.org/show_bug.cgi?id=107816
Reviewed by Pavel Feldman.
'console.debug' is currently aliased to 'console.log'. Since we now
render debug-level messages differently to log messages, we should use
the proper message level for 'console.debug'.
* page/Console.cpp:
(WebCore::Console::debug):
Replace the alias to 'console.log' with message creation at
DebugMessageLevel.
2013-01-24 Dima Gorbik <dgorbik@apple.com>
Implement :past pseudo class for the WebVTT ::cue pseudo element
......@@ -233,8 +233,7 @@ static void internalAddMessage(Page* page, MessageType type, MessageLevel level,
void Console::debug(ScriptState* state, PassRefPtr<ScriptArguments> arguments)
{
// In Firebug, console.debug has the same behavior as console.log. So we'll do the same.
log(state, arguments);
internalAddMessage(page(), LogMessageType, DebugMessageLevel, state, arguments);
}
void Console::error(ScriptState* state, PassRefPtr<ScriptArguments> arguments)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment