Commit 7ffc4030 authored by harrison's avatar harrison

Reviewed by Adele.

        <rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer

        Replace an assert with a fixme that refers to this bug.
        
        * page/Frame.cpp:
        (WebCore::Frame::revealSelection):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent e79e9456
2006-11-17 David Harrison <harrison@apple.com>
Reviewed by Adele.
<rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer
Replace an assert with a fixme that refers to this bug.
* page/Frame.cpp:
(WebCore::Frame::revealSelection):
2006-11-16 Rob Buis <buis@kde.org>
Reviewed and landed by Brady
......@@ -1006,16 +1006,14 @@ void Frame::revealSelection(const RenderLayer::ScrollAlignment& alignment) const
}
Position start = selectionController()->start();
Position end = selectionController()->end();
ASSERT(start.node());
if (start.node() && start.node()->renderer()) {
RenderLayer *layer = start.node()->renderer()->enclosingLayer();
if (layer) {
ASSERT(!end.node() || !end.node()->renderer()
|| (end.node()->renderer()->enclosingLayer() == layer));
// FIXME: This code only handles scrolling the startContainer's layer, but
// the selection rect could intersect more than just that.
// See <rdar://problem/4799899>.
if (RenderLayer *layer = start.node()->renderer()->enclosingLayer())
layer->scrollRectToVisible(rect, alignment, alignment);
}
}
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment