Commit 7ee57d46 authored by reni@webkit.org's avatar reni@webkit.org
Browse files

Missing null-check in HTMLFormElement::rendererIsNeeded()

https://bugs.webkit.org/show_bug.cgi?id=120159

Reviewed by Ryosuke Niwa.

Source/WebCore:

Null-check parentRenderer in HTMLFormElement::rendererIsNeeded()
and early return.

Test: fast/forms/missing-parentrenderer-crash.html

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):

LayoutTests:

Test for the handling of null parentRederer.

* fast/forms/missing-parentrenderer-crash-expected.txt: Added.
* fast/forms/missing-parentrenderer-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent d9b9bdfc
2013-08-23 Renata Hodovan <reni@webkit.org>
Missing null-check in HTMLFormElement::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=120159
Reviewed by Ryosuke Niwa.
Test for the handling of null parentRederer.
* fast/forms/missing-parentrenderer-crash-expected.txt: Added.
* fast/forms/missing-parentrenderer-crash.html: Added.
2013-08-23 Zalan Bujtas <zalan@apple.com>
 
MathML: ASSERTION FAILED: !isPreferredLogicalHeightDirty() in RenderMathMLBlock::preferredLogicalHeight() const
<html>
<blockquote style="-webkit-flow-from: thread;"/>
<table/>
<form/>
<script>
if (window.testRunner)
testRunner.dumpAsText();
document.body.innerHTML = "PASS. WebKit didn't crash.";
</script>
</html>
2013-08-23 Renata Hodovan <reni@webkit.org>
Missing null-check in HTMLFormElement::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=120159
Reviewed by Ryosuke Niwa.
Null-check parentRenderer in HTMLFormElement::rendererIsNeeded()
and early return.
Test: fast/forms/missing-parentrenderer-crash.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
2013-08-23 Zalan Bujtas <zalan@apple.com>
 
MathML: ASSERTION FAILED: !isPreferredLogicalHeightDirty() in RenderMathMLBlock::preferredLogicalHeight() const
......@@ -101,6 +101,10 @@ bool HTMLFormElement::rendererIsNeeded(const RenderStyle& style)
ContainerNode* node = parentNode();
RenderObject* parentRenderer = node->renderer();
if (!parentRenderer)
return false;
// FIXME: Shouldn't we also check for table caption (see |formIsTablePart| below).
bool parentIsTableElementPart = (parentRenderer->isTable() && isHTMLTableElement(node))
|| (parentRenderer->isTableRow() && node->hasTagName(trTag))
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment