Commit 7d412f8d authored by dbates@webkit.org's avatar dbates@webkit.org

Break up single assertion into two assertions in HTMLMediaElement::returnPlatformLayer()

Following up after <http://trac.webkit.org/changeset/162473>, we should break up
the assertion into two assertions as suggested by Darin Adler. Separating the single
assertion into two assertions makes it straightforward to determine the conjunct that
failed among other benefits.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent b63787c1
2014-01-21 Daniel Bates <dabates@apple.com>
Break up single assertion into two assertions in HTMLMediaElement::returnPlatformLayer()
Following up after <http://trac.webkit.org/changeset/162473>, we should break up
the assertion into two assertions as suggested by Darin Adler. Separating the single
assertion into two assertions makes it straightforward to determine the conjunct that
failed among other benefits.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
2014-01-21 Brady Eidson <beidson@apple.com>
The IDB backing store put() method shouldn't call IDB callbacks directly
......@@ -4926,7 +4926,8 @@ PlatformLayer* HTMLMediaElement::borrowPlatformLayer()
void HTMLMediaElement::returnPlatformLayer(PlatformLayer* platformLayer)
{
ASSERT_UNUSED(platformLayer, m_platformLayerBorrowed && platformLayer == (m_player ? m_player->platformLayer() : nullptr));
ASSERT_UNUSED(platformLayer, platformLayer == (m_player ? m_player->platformLayer() : nullptr));
ASSERT(m_platformLayerBorrowed);
m_platformLayerBorrowed = false;
if (renderer())
renderer()->updateFromElement();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment