Commit 7cc04e3c authored by rniwa@webkit.org's avatar rniwa@webkit.org

REGRESSION(r148584): WebKit nightly builds don't load any page

https://bugs.webkit.org/show_bug.cgi?id=114752

Reviewed by Anders Carlsson.

We can't use C++ style (//) comments in Platform.h because WebKit2/DerivedSource.make doesn't know
how to strip it to be merged with *.sb.in to generate *.sb files. Specifically, we have:
        
# Some versions of clang incorrectly strip out // comments in c89 code.
# Use -traditional as a workaround, but only when needed since that causes
# other problems with later versions of clang.
ifeq ($(shell echo '//x' | $(CC) -E -P -x c -std=c89 - | grep x),)
TEXT_PREPROCESSOR_FLAGS=-E -P -x c -traditional -w
else
TEXT_PREPROCESSOR_FLAGS=-E -P -x c -std=c89 -w
endif

* wtf/Platform.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent e2abca3a
2013-04-17 Ryosuke Niwa <rniwa@webkit.org>
REGRESSION(r148584): WebKit nightly builds don't load any page
https://bugs.webkit.org/show_bug.cgi?id=114752
Reviewed by Anders Carlsson.
We can't use C++ style (//) comments in Platform.h because WebKit2/DerivedSource.make doesn't know
how to strip it to be merged with *.sb.in to generate *.sb files. Specifically, we have:
# Some versions of clang incorrectly strip out // comments in c89 code.
# Use -traditional as a workaround, but only when needed since that causes
# other problems with later versions of clang.
ifeq ($(shell echo '//x' | $(CC) -E -P -x c -std=c89 - | grep x),)
TEXT_PREPROCESSOR_FLAGS=-E -P -x c -traditional -w
else
TEXT_PREPROCESSOR_FLAGS=-E -P -x c -std=c89 -w
endif
* wtf/Platform.h:
2013-04-17 Brent Fulgham <bfulgham@webkit.org>
[Windows, WinCairo] Remove Include Settings for Pthreads from WTF
......
......@@ -1027,11 +1027,10 @@
#endif
#if PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070)
// Some platforms provide UI for suggesting autocorrection.
/* Some platforms provide UI for suggesting autocorrection. */
#define WTF_USE_AUTOCORRECTION_PANEL 1
// Some platforms use spelling and autocorrection markers to provide visual cue.
// On such platform, if word with marker is edited, we need to remove the marker.
/* Some platforms use spelling and autocorrection markers to provide visual cue. On such platform, if word with marker is edited, we need to remove the marker. */
#define WTF_USE_MARKER_REMOVAL_UPON_EDITING 1
#endif // #if PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070)
#endif /* #if PLATFORM(MAC) && (PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1070) */
#endif /* WTF_Platform_h */
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment