Commit 7c75f95c authored by aroben@apple.com's avatar aroben@apple.com

Fix RenderContainer's override of addLineBoxRects to match RenderObject's

        RenderContainer::addLineBoxRects was never getting called because its
        parameters didn't match those of RenderObject::addLineBoxRects.

        Reviewed by Mitz Pettel.

        No test possible.

        * rendering/RenderContainer.cpp: Added an optional bool
        useSelectionHeight parameter to match RenderObject's method.
        * rendering/RenderContainer.h: Ditto.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 193f312a
2008-03-20 Adam Roben <aroben@apple.com>
Fix RenderContainer's override of addLineBoxRects to match RenderObject's
RenderContainer::addLineBoxRects was never getting called because its
parameters didn't match those of RenderObject::addLineBoxRects.
Reviewed by Mitz Pettel.
No test possible.
* rendering/RenderContainer.cpp: Added an optional bool
useSelectionHeight parameter to match RenderObject's method.
* rendering/RenderContainer.h: Ditto.
2008-03-20 Marco Barisione <marco.barisione@collabora.co.uk>
Reviewed by Alp Toker.
......@@ -628,7 +628,7 @@ VisiblePosition RenderContainer::positionForCoordinates(int x, int y)
return VisiblePosition(element(), 0, DOWNSTREAM);
}
void RenderContainer::addLineBoxRects(Vector<IntRect>& rects, unsigned start, unsigned end)
void RenderContainer::addLineBoxRects(Vector<IntRect>& rects, unsigned start, unsigned end, bool)
{
if (!m_firstChild && (isInline() || isAnonymousBlock())) {
int x, y;
......
......@@ -61,7 +61,7 @@ public:
virtual VisiblePosition positionForCoordinates(int x, int y);
virtual void addLineBoxRects(Vector<IntRect>&, unsigned startOffset = 0, unsigned endOffset = UINT_MAX);
virtual void addLineBoxRects(Vector<IntRect>&, unsigned startOffset = 0, unsigned endOffset = UINT_MAX, bool useSelectionHeight = false);
private:
RenderObject* m_firstChild;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment