Convert disable-msg to disable for new pylint.

https://bugs.webkit.org/show_bug.cgi?id=107627

Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-22
Reviewed by Eric Seidel.

* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm):
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Builder.force_build):
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive2.run_command):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.reference_files):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_default_configuration):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_expectations_ordering):
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase._check_that_all_ports_are_available):
* Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand.execute):
* Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(AbstractParallelRebaselineCommand):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase.setUp):
(TestAnalyzeBaselines.setUp):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 80be365a
2013-01-22 Tim 'mithro' Ansell <mithro@mithis.com>
Convert disable-msg to disable for new pylint.
https://bugs.webkit.org/show_bug.cgi?id=107627
Reviewed by Eric Seidel.
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository.has_authorization_for_realm):
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Builder.force_build):
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive2.run_command):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.reference_files):
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_default_configuration):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_expectations_ordering):
* Scripts/webkitpy/layout_tests/servers/http_server_base.py:
(HttpServerBase._check_that_all_ports_are_available):
* Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
(AbstractLocalServerCommand.execute):
* Scripts/webkitpy/tool/commands/download.py:
(AbstractPatchProcessingCommand):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractRebaseliningCommand):
(AbstractParallelRebaselineCommand):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_BaseTestCase.setUp):
(TestAnalyzeBaselines.setUp):
2013-01-22 Frank Farzan <frankf@chromium.org>
Flakiness dashboard: update builders.jsonp
......
......@@ -54,7 +54,7 @@ class SVNRepository(object):
# If we are working on a file:// repository realm will be None
if realm is None:
return True
# ignore false positives for methods implemented in the mixee class. pylint: disable-msg=E1101
# ignore false positives for methods implemented in the mixee class. pylint: disable=E1101
# Assumes find and grep are installed.
if not os.path.isdir(os.path.join(home_directory, ".subversion")):
return False
......
......@@ -131,7 +131,7 @@ class Builder(object):
return form.find_control("username")
except Exception, e:
return False
# ignore false positives for missing Browser methods - pylint: disable-msg=E1102
# ignore false positives for missing Browser methods - pylint: disable=E1102
self._browser.open(self.url())
self._browser.select_form(predicate=predicate)
self._browser["username"] = username
......
......@@ -178,7 +178,7 @@ class MockExecutive2(MockExecutive):
self.calls.append(args)
assert(isinstance(args, list) or isinstance(args, tuple))
if self._exception:
raise self._exception # pylint: disable-msg=E0702
raise self._exception # pylint: disable=E0702
if self._run_command_fn:
return self._run_command_fn(args)
if return_exit_code:
......
......@@ -580,7 +580,7 @@ class Port(object):
reftest_list.append((expectation, path))
return reftest_list
return reftest_list.get(self._filesystem.join(self.layout_tests_dir(), test_name), []) # pylint: disable-msg=E1103
return reftest_list.get(self._filesystem.join(self.layout_tests_dir(), test_name), []) # pylint: disable=E1103
def tests(self, paths):
"""Return the list of tests found. Both generic and platform-specific tests matching paths should be returned."""
......
......@@ -130,12 +130,12 @@ class ChromiumPortTestCase(port_testcase.PortTestCase):
def test_default_configuration(self):
mock_options = MockOptions()
port = ChromiumPortTestCase.TestLinuxPort(options=mock_options)
self.assertEqual(mock_options.configuration, 'default') # pylint: disable-msg=E1101
self.assertEqual(mock_options.configuration, 'default') # pylint: disable=E1101
self.assertTrue(port.default_configuration_called)
mock_options = MockOptions(configuration=None)
port = ChromiumPortTestCase.TestLinuxPort(mock_options)
self.assertEqual(mock_options.configuration, 'default') # pylint: disable-msg=E1101
self.assertEqual(mock_options.configuration, 'default') # pylint: disable=E1101
self.assertTrue(port.default_configuration_called)
def test_diff_image(self):
......
......@@ -433,7 +433,7 @@ class PortTestCase(unittest.TestCase):
port._filesystem.write_text_file('/tmp/foo', 'foo')
port._filesystem.write_text_file('/tmp/bar', 'bar')
ordered_dict = port.expectations_dict()
self.assertEqual(ordered_dict.keys()[-2:], options.additional_expectations) # pylint: disable-msg=E1101
self.assertEqual(ordered_dict.keys()[-2:], options.additional_expectations) # pylint: disable=E1101
self.assertEqual(ordered_dict.values()[-2:], ['foo', 'bar'])
def test_path_to_test_expectations_file(self):
......
......@@ -193,7 +193,7 @@ class HttpServerBase(object):
except IOError, e:
if e.errno in (errno.EALREADY, errno.EADDRINUSE):
raise ServerError('Port %d is already in use.' % port)
elif sys.platform == 'win32' and e.errno in (errno.WSAEACCES,): # pylint: disable-msg=E1101
elif sys.platform == 'win32' and e.errno in (errno.WSAEACCES,): # pylint: disable=E1101
raise ServerError('Port %d is already in use.' % port)
else:
raise
......
......@@ -53,5 +53,5 @@ class AbstractLocalServerCommand(AbstractDeclarativeCommand):
# FIXME: This seems racy.
threading.Timer(0.1, lambda: self._tool.user.open_url(server_url)).start()
httpd = self.server(httpd_port=options.httpd_port, config=config) # pylint: disable-msg=E1102
httpd = self.server(httpd_port=options.httpd_port, config=config) # pylint: disable=E1102
httpd.serve_forever()
......@@ -149,7 +149,7 @@ class AbstractPatchProcessingCommand(AbstractDeclarativeCommand):
# Subclasses must implement the methods below. We don't declare them here
# because we want to be able to implement them with mix-ins.
#
# pylint: disable-msg=E1101
# pylint: disable=E1101
# def _fetch_list_of_patches_to_process(self, options, args, tool):
# def _prepare_to_process(self, options, args, tool):
# def _process_patch(self, options, args, tool):
......
......@@ -50,7 +50,7 @@ def _baseline_name(fs, test_name, suffix):
class AbstractRebaseliningCommand(AbstractDeclarativeCommand):
# not overriding execute() - pylint: disable-msg=W0223
# not overriding execute() - pylint: disable=W0223
move_overwritten_baselines_option = optparse.make_option("--move-overwritten-baselines", action="store_true", default=False,
help="Move overwritten baselines elsewhere in the baseline path. This is for bringing up new ports.")
......@@ -266,7 +266,7 @@ class AnalyzeBaselines(AbstractRebaseliningCommand):
class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
# not overriding execute() - pylint: disable-msg=W0223
# not overriding execute() - pylint: disable=W0223
def _run_webkit_patch(self, args, verbose):
try:
......
......@@ -45,7 +45,7 @@ class _BaseTestCase(unittest.TestCase):
def setUp(self):
self.tool = MockTool()
self.command = self.command_constructor() # lint warns that command_constructor might not be set, but this is intentional; pylint: disable-msg=E1102
self.command = self.command_constructor() # lint warns that command_constructor might not be set, but this is intentional; pylint: disable=E1102
self.command.bind_to_tool(self.tool)
self.lion_port = self.tool.port_factory.get_from_builder_name("WebKit Mac10.7")
self.lion_expectations_path = self.lion_port.path_to_test_expectations_file()
......@@ -383,7 +383,7 @@ class TestAnalyzeBaselines(_BaseTestCase):
self.tool.port_factory.get = (lambda port_name=None, options=None: self.port)
self.lines = []
self.command._optimizer_class = _FakeOptimizer
self.command._write = (lambda msg: self.lines.append(msg)) # pylint bug warning about unnecessary lambda? pylint: disable-msg=W0108
self.command._write = (lambda msg: self.lines.append(msg)) # pylint bug warning about unnecessary lambda? pylint: disable=W0108
def test_default(self):
self.command.execute(MockOptions(suffixes='txt', missing=False, platform=None), ['passes/text.html'], self.tool)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment