Commit 77ea93c8 authored by zandobersek@gmail.com's avatar zandobersek@gmail.com

[Dashboard] Clean up the timeline updating code, removing Chromium-specific cases

https://bugs.webkit.org/show_bug.cgi?id=114756

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-17
Reviewed by Ryosuke Niwa.

Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
constructing the results URL and removing the possible row addition containing the Chromium commit range that
only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
method.

* TestResultServer/static-dashboards/timeline_explorer.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent bd95c851
2013-04-17 Zan Dobersek <zandobersek@gmail.com>
[Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
https://bugs.webkit.org/show_bug.cgi?id=114756
Reviewed by Ryosuke Niwa.
Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
constructing the results URL and removing the possible row addition containing the Chromium commit range that
only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
method.
* TestResultServer/static-dashboards/timeline_explorer.js:
2013-04-17 Alberto Garcia <agarcia@igalia.com>
media-stream and xslt are no longer configurable options in the GTK+ port
......@@ -111,11 +111,6 @@ function initCurrentBuilderTestResults()
console.log( 'Time to get test results by build: ' + (Date.now() - startTime));
}
function shouldShowWebKitRevisionsOnly()
{
return isTipOfTreeWebKitBuilder();
}
function updateTimelineForBuilder()
{
var builder = g_history.dashboardSpecificState.builder || currentBuilderGroup().defaultBuilder();
......@@ -229,19 +224,12 @@ function updateBuildInspector(results, builder, dygraph, index)
addRow('', '');
var master = builderMaster(builder);
var buildUrl = master.logPath(builder, results[BUILD_NUMBERS_KEY][index]);
if (master.name == WEBKIT_BUILDER_MASTER) {
var resultsUrl = 'http://build.webkit.org/results/' + builder + '/r' + results[WEBKIT_REVISIONS_KEY][index] +
' (' + results[BUILD_NUMBERS_KEY][index] + ')';
} else {
var resultsUrl = 'http://build.chromium.org/f/chromium/layout_test_results/' +
currentBuilders()[builder] + '/' + results[CHROME_REVISIONS_KEY][index];
}
var resultsUrl = 'http://build.webkit.org/results/' + builder + '/r' + results[WEBKIT_REVISIONS_KEY][index] +
' (' + results[BUILD_NUMBERS_KEY][index] + ')';
addRow('Build:', '<a href="' + buildUrl + '" target="_blank">' + buildNumber + '</a> (<a href="' + resultsUrl + '" target="_blank">results</a>)');
// Revision link(s)
if (!shouldShowWebKitRevisionsOnly())
addRow('Chromium change:', ui.html.chromiumRevisionLink(results, index));
// Revision link
addRow('WebKit change:', ui.html.webKitRevisionLink(results, index));
// Test status/counts
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment