Commit 75cfa4d4 authored by dino@apple.com's avatar dino@apple.com

<https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog

Reviewed by Mark Rowe.

Have prepare-ChangeLog produce webkit.org/b/id style
URLs rather than exposing the inner workings of our
cgi. I was going to use the term "Future Proofing"
but that seems excessive :)

* Scripts/prepare-ChangeLog:
(main): Generate a more human readable form.
(generateNewChangeLogs): Use it when printing out the ChangeLog entry.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 95e54306
2013-08-13 Dean Jackson <dino@apple.com>
<https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
Reviewed by Mark Rowe.
Have prepare-ChangeLog produce webkit.org/b/id style
URLs rather than exposing the inner workings of our
cgi. I was going to use the term "Future Proofing"
but that seems excessive :)
* Scripts/prepare-ChangeLog:
(main): Generate a more human readable form.
(generateNewChangeLogs): Use it when printing out the ChangeLog entry.
2013-08-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
[EFL][DRT] Simplify call to reverseFind()
......
......@@ -22,7 +22,6 @@
# Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
#
# Perl script to create a ChangeLog entry with names of files
# and functions from a diff.
#
......@@ -79,7 +78,7 @@ sub findChangeLogs($);
sub findOriginalFileFromSvn($);
sub generateFileList(\%$$$);
sub generateFunctionLists($$$$$);
sub generateNewChangeLogs($$$$$$$$$$$);
sub generateNewChangeLogs($$$$$$$$$$$$);
sub getLatestChangeLogs($);
sub get_function_line_ranges($$);
sub get_function_line_ranges_for_cpp($$);
......@@ -195,8 +194,10 @@ sub main()
$name =~ s/\(.*?\)\s*$//g;
my $bugURL;
my $readableBugURL;
if ($bugNumber) {
$bugURL = "https://bugs.webkit.org/show_bug.cgi?id=$bugNumber";
$readableBugURL = "https://webkit.org/b/$bugNumber";
}
if ($bugNumber && !$bugDescription) {
......@@ -212,7 +213,7 @@ sub main()
resolveConflictedChangeLogs($changeLogs);
}
generateNewChangeLogs($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $gitCommit, $writeChangeLogs);
generateNewChangeLogs($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $readableBugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $gitCommit, $writeChangeLogs);
if ($writeChangeLogs) {
print STDERR "-- Please remember to include a detailed description in your ChangeLog entry. --\n-- See <http://webkit.org/coding/contributing.html> for more info --\n";
......@@ -459,9 +460,9 @@ sub resolveConflictedChangeLogs($)
close RESOLVE;
}
sub generateNewChangeLogs($$$$$$$$$$$)
sub generateNewChangeLogs($$$$$$$$$$$$)
{
my ($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $gitCommit, $writeChangeLogs) = @_;
my ($prefixes, $filesInChangeLog, $addedRegressionTests, $functionLists, $bugURL, $readableBugURL, $bugDescription, $name, $emailAddress, $gitReviewer, $gitCommit, $writeChangeLogs) = @_;
# Generate new ChangeLog entries and (optionally) write out new ChangeLog files.
foreach my $prefix (@$prefixes) {
......@@ -495,9 +496,9 @@ sub generateNewChangeLogs($$$$$$$$$$$)
print CHANGE_LOG normalizeLineEndings($description . "\n", $endl) if $description;
$bugDescription = "Need a short description (OOPS!).\n Need the bug URL (OOPS!)." unless $bugDescription;
print CHANGE_LOG normalizeLineEndings(" $bugDescription\n", $endl) if $bugDescription;
print CHANGE_LOG normalizeLineEndings(" $bugURL\n", $endl) if $bugURL;
$bugDescription = "Need a short description (OOPS!)" unless $bugDescription;
$readableBugURL = "Need the bug URL (OOPS!)" unless $readableBugURL;
print CHANGE_LOG normalizeLineEndings(" <$readableBugURL> $bugDescription\n", $endl);
print CHANGE_LOG normalizeLineEndings("\n", $endl);
print CHANGE_LOG normalizeLineEndings(" Reviewed by $reviewer.\n\n", $endl);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment