Commit 72b14d6f authored by haraken@chromium.org's avatar haraken@chromium.org

Add the "JS" prefix to JSC specific IDL attributes

https://bugs.webkit.org/show_bug.cgi?id=77693

Reviewed by Darin Adler.

Some JSC specific IDLs do not have "JS" prefix, e.g. [CustomIsReachable].
It might be OK since JSC is the main JavaScript engine in WebKit, but
distinguishing IDLs widely used in WebKit and IDLs used in JSC only would help
people understand the role of IDLs.

This patch renames the following JSC specific IDLs:

    CustomFinalize => JSCustomFinalize
    CustomIsReachable => JSCustomIsReachable
    CustomMarkFunction => JSCustomMarkFunction
    CustomToJS => JSCustomToJS
    CustomNativeConverter => JSCustomToNativeObject (Note: For naming consistency with [JSCustomToJS])
    GenerateIsReachable => JSGenerateIsReachable
    GenerateToJS => JSGenerateToJS
    NoStaticTables => JSNoStaticTables
    WindowEventListener => JSWindowEventListener
    InlineGetOwnPropertySlot => JSInlineGetOwnPropertySlot
    DelegatingPrototypePutFunction => JSCustomPrototypePutDelegate

No tests. No changes in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(HasCustomToV8Implementation):

* bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.

* css/CSSRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* dom/Attr.idl:
* dom/DOMCoreException.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringMap.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/ErrorEvent.idl:
* dom/Event.idl:
* dom/EventException.idl:
* dom/EventListener.idl:
* dom/MessageChannel.idl:
* dom/MessageEvent.idl:
* dom/MessagePort.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeIterator.idl:
* dom/NodeList.idl:
* dom/TreeWalker.idl:
* dom/WebKitNamedFlow.idl:
* fileapi/Blob.idl:
* fileapi/DOMFileSystem.idl:
* fileapi/DOMFileSystemSync.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/DirectoryReader.idl:
* fileapi/DirectoryReaderSync.idl:
* fileapi/Entry.idl:
* fileapi/EntryArray.idl:
* fileapi/EntryArraySync.idl:
* fileapi/EntrySync.idl:
* fileapi/File.idl:
* fileapi/FileEntry.idl:
* fileapi/FileEntrySync.idl:
* fileapi/FileError.idl:
* fileapi/FileException.idl:
* fileapi/FileList.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:
* fileapi/FileWriter.idl:
* fileapi/Metadata.idl:
* fileapi/OperationNotAllowedException.idl:
* fileapi/WebKitBlobBuilder.idl:
* html/DOMFormData.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLAllCollection.idl:
* html/HTMLBodyElement.idl:
* html/HTMLCollection.idl:
* html/HTMLFrameSetElement.idl:
* html/ImageData.idl:
* html/MediaController.idl:
* html/TextTrack.idl:
* html/TextTrackCue.idl:
* html/VoidCallback.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.idl:
* html/canvas/CanvasRenderingContext.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/canvas/WebGLCompressedTextures.idl:
* html/canvas/WebGLDebugRendererInfo.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLLoseContext.idl:
* html/canvas/WebGLRenderingContext.idl:
* html/track/TextTrackList.idl:
* loader/appcache/DOMApplicationCache.idl:
* mediastream/LocalMediaStream.idl:
* page/BarInfo.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/DOMWindow.idl:
* page/EventSource.idl:
* page/Geolocation.idl:
* page/History.idl:
* page/Location.idl:
* page/Navigator.idl:
* page/Screen.idl:
* page/WorkerNavigator.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPluginArray.idl:
* storage/Database.idl:
* storage/DatabaseSync.idl:
* storage/IDBAny.idl:
* storage/IDBKey.idl:
* storage/SQLError.idl:
* storage/SQLException.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* storage/SQLTransactionSync.idl:
* storage/Storage.idl:
* svg/SVGElementInstance.idl:
* svg/SVGPathSeg.idl:
* webaudio/AudioBufferCallback.idl:
* webaudio/AudioBufferSourceNode.idl:
* webaudio/AudioContext.idl:
* webaudio/AudioDestinationNode.idl:
* webaudio/AudioGain.idl:
* webaudio/AudioGainNode.idl:
* webaudio/AudioPannerNode.idl:
* webaudio/AudioProcessingEvent.idl:
* webaudio/BiquadFilterNode.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DelayNode.idl:
* webaudio/DynamicsCompressorNode.idl:
* webaudio/HighPass2FilterNode.idl:
* webaudio/JavaScriptAudioNode.idl:
* webaudio/LowPass2FilterNode.idl:
* webaudio/MediaElementAudioSourceNode.idl:
* webaudio/OfflineAudioCompletionEvent.idl:
* webaudio/RealtimeAnalyserNode.idl:
* webaudio/WaveShaperNode.idl:
* websockets/CloseEvent.idl:
* websockets/WebSocket.idl:
* workers/AbstractWorker.idl:
* workers/DedicatedWorkerContext.idl:
* workers/SharedWorker.idl:
* workers/SharedWorkerContext.idl:
* workers/Worker.idl:
* workers/WorkerContext.idl:
* workers/WorkerLocation.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestException.idl:
* xml/XMLHttpRequestProgressEvent.idl:
* xml/XMLHttpRequestUpload.idl:
* xml/XPathResult.idl:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 61e09331
2012-02-04 Kentaro Hara <haraken@chromium.org>
Add the "JS" prefix to JSC specific IDL attributes
https://bugs.webkit.org/show_bug.cgi?id=77693
Reviewed by Darin Adler.
Some JSC specific IDLs do not have "JS" prefix, e.g. [CustomIsReachable].
It might be OK since JSC is the main JavaScript engine in WebKit, but
distinguishing IDLs widely used in WebKit and IDLs used in JSC only would help
people understand the role of IDLs.
This patch renames the following JSC specific IDLs:
CustomFinalize => JSCustomFinalize
CustomIsReachable => JSCustomIsReachable
CustomMarkFunction => JSCustomMarkFunction
CustomToJS => JSCustomToJS
CustomNativeConverter => JSCustomToNativeObject (Note: For naming consistency with [JSCustomToJS])
GenerateIsReachable => JSGenerateIsReachable
GenerateToJS => JSGenerateToJS
NoStaticTables => JSNoStaticTables
WindowEventListener => JSWindowEventListener
InlineGetOwnPropertySlot => JSInlineGetOwnPropertySlot
DelegatingPrototypePutFunction => JSCustomPrototypePutDelegate
No tests. No changes in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(HasCustomToV8Implementation):
* bindings/scripts/test/TestTypedArray.idl: No change in run-bindings-tests results.
* css/CSSRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValue.idl:
* css/MediaList.idl:
* css/MediaQueryListListener.idl:
* css/StyleMedia.idl:
* css/StyleSheet.idl:
* css/StyleSheetList.idl:
* dom/Attr.idl:
* dom/DOMCoreException.idl:
* dom/DOMImplementation.idl:
* dom/DOMStringMap.idl:
* dom/Document.idl:
* dom/Element.idl:
* dom/ErrorEvent.idl:
* dom/Event.idl:
* dom/EventException.idl:
* dom/EventListener.idl:
* dom/MessageChannel.idl:
* dom/MessageEvent.idl:
* dom/MessagePort.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeFilter.idl:
* dom/NodeIterator.idl:
* dom/NodeList.idl:
* dom/TreeWalker.idl:
* dom/WebKitNamedFlow.idl:
* fileapi/Blob.idl:
* fileapi/DOMFileSystem.idl:
* fileapi/DOMFileSystemSync.idl:
* fileapi/DirectoryEntry.idl:
* fileapi/DirectoryEntrySync.idl:
* fileapi/DirectoryReader.idl:
* fileapi/DirectoryReaderSync.idl:
* fileapi/Entry.idl:
* fileapi/EntryArray.idl:
* fileapi/EntryArraySync.idl:
* fileapi/EntrySync.idl:
* fileapi/File.idl:
* fileapi/FileEntry.idl:
* fileapi/FileEntrySync.idl:
* fileapi/FileError.idl:
* fileapi/FileException.idl:
* fileapi/FileList.idl:
* fileapi/FileReader.idl:
* fileapi/FileReaderSync.idl:
* fileapi/FileWriter.idl:
* fileapi/Metadata.idl:
* fileapi/OperationNotAllowedException.idl:
* fileapi/WebKitBlobBuilder.idl:
* html/DOMFormData.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/DOMURL.idl:
* html/HTMLAllCollection.idl:
* html/HTMLBodyElement.idl:
* html/HTMLCollection.idl:
* html/HTMLFrameSetElement.idl:
* html/ImageData.idl:
* html/MediaController.idl:
* html/TextTrack.idl:
* html/TextTrackCue.idl:
* html/VoidCallback.idl:
* html/canvas/ArrayBuffer.idl:
* html/canvas/ArrayBufferView.idl:
* html/canvas/CanvasRenderingContext.idl:
* html/canvas/DataView.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/OESStandardDerivatives.idl:
* html/canvas/OESTextureFloat.idl:
* html/canvas/OESVertexArrayObject.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/canvas/WebGLCompressedTextures.idl:
* html/canvas/WebGLDebugRendererInfo.idl:
* html/canvas/WebGLDebugShaders.idl:
* html/canvas/WebGLLoseContext.idl:
* html/canvas/WebGLRenderingContext.idl:
* html/track/TextTrackList.idl:
* loader/appcache/DOMApplicationCache.idl:
* mediastream/LocalMediaStream.idl:
* page/BarInfo.idl:
* page/Console.idl:
* page/DOMSelection.idl:
* page/DOMWindow.idl:
* page/EventSource.idl:
* page/Geolocation.idl:
* page/History.idl:
* page/Location.idl:
* page/Navigator.idl:
* page/Screen.idl:
* page/WorkerNavigator.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPluginArray.idl:
* storage/Database.idl:
* storage/DatabaseSync.idl:
* storage/IDBAny.idl:
* storage/IDBKey.idl:
* storage/SQLError.idl:
* storage/SQLException.idl:
* storage/SQLResultSet.idl:
* storage/SQLResultSetRowList.idl:
* storage/SQLTransaction.idl:
* storage/SQLTransactionSync.idl:
* storage/Storage.idl:
* svg/SVGElementInstance.idl:
* svg/SVGPathSeg.idl:
* webaudio/AudioBufferCallback.idl:
* webaudio/AudioBufferSourceNode.idl:
* webaudio/AudioContext.idl:
* webaudio/AudioDestinationNode.idl:
* webaudio/AudioGain.idl:
* webaudio/AudioGainNode.idl:
* webaudio/AudioPannerNode.idl:
* webaudio/AudioProcessingEvent.idl:
* webaudio/BiquadFilterNode.idl:
* webaudio/ConvolverNode.idl:
* webaudio/DelayNode.idl:
* webaudio/DynamicsCompressorNode.idl:
* webaudio/HighPass2FilterNode.idl:
* webaudio/JavaScriptAudioNode.idl:
* webaudio/LowPass2FilterNode.idl:
* webaudio/MediaElementAudioSourceNode.idl:
* webaudio/OfflineAudioCompletionEvent.idl:
* webaudio/RealtimeAnalyserNode.idl:
* webaudio/WaveShaperNode.idl:
* websockets/CloseEvent.idl:
* websockets/WebSocket.idl:
* workers/AbstractWorker.idl:
* workers/DedicatedWorkerContext.idl:
* workers/SharedWorker.idl:
* workers/SharedWorkerContext.idl:
* workers/Worker.idl:
* workers/WorkerContext.idl:
* workers/WorkerLocation.idl:
* xml/XMLHttpRequest.idl:
* xml/XMLHttpRequestException.idl:
* xml/XMLHttpRequestProgressEvent.idl:
* xml/XMLHttpRequestUpload.idl:
* xml/XPathResult.idl:
2012-02-04 Emil A Eklund <eae@chromium.org>
Convert RenderTheme over to new layout abstraction
......@@ -3139,7 +3139,7 @@ sub HasCustomToV8Implementation {
return 0 if $interfaceName eq "TextTrack";
# For everything else, do what JSC does.
return $dataNode->extendedAttributes->{"CustomToJS"};
return $dataNode->extendedAttributes->{"JSCustomToJS"};
}
sub GetDomMapFunction
......
......@@ -30,8 +30,8 @@ module html {
HasNumericIndexGetter,
HasCustomIndexSetter,
GenerateNativeConverter,
NoStaticTables,
CustomToJS,
JSNoStaticTables,
JSCustomToJS,
DontCheckEnums
] Float64Array : ArrayBufferView {
Int32Array foo(in Float32Array array);
......
......@@ -22,9 +22,9 @@ module css {
// Introduced in DOM Level 2:
interface [
CustomMarkFunction,
GenerateIsReachable,
CustomToJS,
JSCustomMarkFunction,
JSGenerateIsReachable,
JSCustomToJS,
ObjCPolymorphic,
V8DependentLifetime
] CSSRule {
......
......@@ -27,7 +27,7 @@ module css {
// Introduced in DOM Level 2:
interface [
CustomIsReachable,
JSCustomIsReachable,
HasIndexGetter,
V8DependentLifetime
] CSSRuleList {
......
......@@ -22,8 +22,8 @@ module css {
// Introduced in DOM Level 2:
interface [
CustomMarkFunction,
GenerateIsReachable=ImplRoot,
JSCustomMarkFunction,
JSGenerateIsReachable=ImplRoot,
DelegatingPutFunction,
HasNameGetter,
HasIndexGetter,
......
......@@ -21,9 +21,9 @@
module css {
interface [
CustomToJS,
CustomIsReachable,
CustomFinalize,
JSCustomToJS,
JSCustomIsReachable,
JSCustomFinalize,
ObjCPolymorphic,
V8DependentLifetime
] CSSValue {
......
......@@ -27,7 +27,7 @@ module stylesheets {
// Introduced in DOM Level 2:
interface [
GenerateIsReachable,
JSGenerateIsReachable,
HasIndexGetter
] MediaList {
......
......@@ -19,7 +19,7 @@
module view {
interface [
NoStaticTables,
JSNoStaticTables,
ObjCProtocol,
CPPPureInterface,
OmitConstructor
......
......@@ -26,7 +26,7 @@
module view {
interface [
GenerateIsReachable=ImplFrame
JSGenerateIsReachable=ImplFrame
] StyleMedia {
readonly attribute DOMString type;
boolean matchMedium(in [Optional=CallWithDefaultValue] DOMString mediaquery);
......
......@@ -22,9 +22,9 @@ module stylesheets {
// Introduced in DOM Level 2:
interface [
CustomMarkFunction,
GenerateIsReachable,
CustomToJS,
JSCustomMarkFunction,
JSGenerateIsReachable,
JSCustomToJS,
ObjCPolymorphic,
V8DependentLifetime
] StyleSheet {
......
......@@ -22,7 +22,7 @@ module stylesheets {
// Introduced in DOM Level 2:
interface [
GenerateIsReachable=ImplDocument,
JSGenerateIsReachable=ImplDocument,
HasIndexGetter,
HasNameGetter,
V8DependentLifetime
......
......@@ -21,7 +21,7 @@
module core {
interface [
CustomMarkFunction,
JSCustomMarkFunction,
GenerateNativeConverter
] Attr : Node {
......
......@@ -29,7 +29,7 @@
module core {
interface [
NoStaticTables,
JSNoStaticTables,
DontCheckEnums
] DOMCoreException {
......
......@@ -21,7 +21,7 @@
module core {
interface [
GenerateIsReachable=ImplDocument,
JSGenerateIsReachable=ImplDocument,
V8DependentLifetime
] DOMImplementation {
......
......@@ -26,7 +26,7 @@
module core {
interface [
GenerateIsReachable=ImplElementRoot,
JSGenerateIsReachable=ImplElementRoot,
HasNameGetter,
CustomDeleteProperty,
CustomGetPropertyNames,
......
......@@ -21,9 +21,9 @@
module core {
interface [
CustomToJS,
JSCustomToJS,
GenerateNativeConverter,
InlineGetOwnPropertySlot
JSInlineGetOwnPropertySlot
] Document : Node {
// DOM Level 1 Core
......
......@@ -22,7 +22,7 @@ module core {
interface [
GenerateNativeConverter,
InlineGetOwnPropertySlot
JSInlineGetOwnPropertySlot
] Element : Node {
// DOM Level 1 Core
......
......@@ -31,7 +31,7 @@
module events {
interface [
NoStaticTables,
JSNoStaticTables,
ConstructorTemplate=Event
] ErrorEvent : Event {
readonly attribute [InitializedByEventConstructor] DOMString message;
......
......@@ -22,9 +22,9 @@ module events {
// Introduced in DOM Level 2:
interface [
CustomToJS,
JSCustomToJS,
ConstructorTemplate=Event,
NoStaticTables,
JSNoStaticTables,
ObjCPolymorphic
] Event {
......
......@@ -30,7 +30,7 @@ module events {
// Introduced in DOM Level 2:
interface [
NoStaticTables,
JSNoStaticTables,
DontCheckEnums
] EventException {
......
......@@ -22,7 +22,7 @@ module events {
// Introduced in DOM Level 2:
interface [
NoStaticTables,
JSNoStaticTables,
ObjCProtocol,
CPPPureInterface,
OmitConstructor
......
......@@ -30,8 +30,8 @@ module events {
Constructor,
CallWith=ScriptExecutionContext,
V8CustomConstructor,
CustomMarkFunction,
NoStaticTables
JSCustomMarkFunction,
JSNoStaticTables
] MessageChannel {
readonly attribute MessagePort port1;
......
......@@ -28,7 +28,7 @@
module events {
interface [
NoStaticTables,
JSNoStaticTables,
ConstructorTemplate=Event
] MessageEvent : Event {
readonly attribute [InitializedByEventConstructor] DOMString origin;
......
......@@ -28,11 +28,11 @@
module events {
interface [
CustomMarkFunction,
GenerateIsReachable=Impl,
JSCustomMarkFunction,
JSGenerateIsReachable=Impl,
ActiveDOMObject,
EventTarget,
NoStaticTables
JSNoStaticTables
] MessagePort {
// We need to have something as an ObjC binding, because MessagePort is used in MessageEvent, which already has one,
// but we don't want to actually expose the API while it is in flux.
......
......@@ -21,8 +21,8 @@
module core {
interface [
GenerateIsReachable=ImplElementRoot,
CustomMarkFunction,
JSGenerateIsReachable=ImplElementRoot,
JSCustomMarkFunction,
HasIndexGetter,
HasNameGetter
] NamedNodeMap {
......
......@@ -22,14 +22,14 @@ module core {
interface [
CustomHeader,
CustomMarkFunction,
JSCustomMarkFunction,
CustomPushEventHandlerScope,
CustomIsReachable,
CustomFinalize,
CustomToJS,
JSCustomIsReachable,
JSCustomFinalize,
JSCustomToJS,
EventTarget,
GenerateNativeConverter,
InlineGetOwnPropertySlot,
JSInlineGetOwnPropertySlot,
ObjCPolymorphic,
V8DependentLifetime
] Node
......
......@@ -22,8 +22,8 @@ module traversal {
// Introduced in DOM Level 2:
interface [
CustomMarkFunction,
CustomNativeConverter,
JSCustomMarkFunction,
JSCustomToNativeObject,
ObjCProtocol,
CPPPureInterface
] NodeFilter {
......
......@@ -22,7 +22,7 @@ module traversal {
// Introduced in DOM Level 2:
interface [
CustomMarkFunction
JSCustomMarkFunction
] NodeIterator {
readonly attribute Node root;
readonly attribute unsigned long whatToShow;
......
......@@ -21,7 +21,7 @@
module core {
interface [
CustomIsReachable,
JSCustomIsReachable,
HasIndexGetter,
HasNameGetter
] NodeList {
......
......@@ -22,7 +22,7 @@ module traversal {
// Introduced in DOM Level 2:
interface [
CustomMarkFunction
JSCustomMarkFunction
] TreeWalker {
readonly attribute Node root;
readonly attribute unsigned long whatToShow;
......
......@@ -29,7 +29,7 @@
module core {
interface [
GenerateToJS
JSGenerateToJS
] WebKitNamedFlow {
};
}
......@@ -31,9 +31,9 @@
module html {
interface [
GenerateIsReachable=Impl,
CustomToJS,
NoStaticTables
JSGenerateIsReachable=Impl,
JSCustomToJS,
JSNoStaticTables
] Blob {
readonly attribute unsigned long long size;
readonly attribute DOMString type;
......
......@@ -33,7 +33,7 @@ module storage {
interface [
Conditional=FILE_SYSTEM,
ActiveDOMObject,
NoStaticTables
JSNoStaticTables
] DOMFileSystem {
readonly attribute DOMString name;
readonly attribute DirectoryEntry root;
......
......@@ -31,7 +31,7 @@
module storage {
interface [
Conditional=FILE_SYSTEM,
NoStaticTables
JSNoStaticTables
] DOMFileSystemSync {
readonly attribute DOMString name;
readonly attribute DirectoryEntrySync root;
......
......@@ -32,8 +32,8 @@ module storage {
interface [
Conditional=FILE_SYSTEM,
GenerateNativeConverter,
GenerateToJS,
NoStaticTables
JSGenerateToJS,
JSNoStaticTables
] DirectoryEntry : Entry {
DirectoryReader createReader();