Commit 70850529 authored by haraken@chromium.org's avatar haraken@chromium.org

Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL

https://bugs.webkit.org/show_bug.cgi?id=77963

Reviewed by Adam Barth.

This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
* bindings/scripts/test/TestInterface.idl:
* css/CSSStyleDeclaration.idl:
* dom/DOMStringMap.idl:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 3006ce7c
2012-02-08 Kentaro Hara <haraken@chromium.org>
Rename [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL
https://bugs.webkit.org/show_bug.cgi?id=77963
Reviewed by Adam Barth.
This patch renames [DelegatingPutFunction] IDL to [CustomNamedSetter] IDL,
for clarification and for naming consistency with [NamedGetter] and [CustomIndexedSetter].
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
* bindings/scripts/test/TestInterface.idl:
* css/CSSStyleDeclaration.idl:
* dom/DOMStringMap.idl:
* html/HTMLAppletElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLObjectElement.idl:
* page/History.idl:
* page/Location.idl:
* storage/Storage.idl:
2012-02-08 Kentaro Hara <haraken@chromium.org>
Replace [CheckNodeSecurity] with [CheckAccessToNode]
......@@ -751,7 +751,7 @@ sub GenerateHeader
$headerTrailingIncludes{"${className}Custom.h"} = 1 if $dataNode->extendedAttributes->{"CustomHeader"};
$implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"CustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"DelegatingPutFunction"});
$implIncludes{"${className}Custom.h"} = 1 if !$dataNode->extendedAttributes->{"CustomHeader"} && ($dataNode->extendedAttributes->{"CustomPutFunction"} || $dataNode->extendedAttributes->{"CustomNamedSetter"});
my $hasGetter = $numAttributes > 0
|| !$dataNode->extendedAttributes->{"OmitConstructor"}
......@@ -782,14 +782,14 @@ sub GenerateHeader
my $hasSetter = $hasReadWriteProperties
|| $dataNode->extendedAttributes->{"CustomPutFunction"}
|| $dataNode->extendedAttributes->{"DelegatingPutFunction"}
|| $dataNode->extendedAttributes->{"CustomNamedSetter"}
|| $dataNode->extendedAttributes->{"CustomIndexedSetter"};
# Getters
if ($hasSetter) {
push(@headerContent, " static void put(JSC::JSCell*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSValue, JSC::PutPropertySlot&);\n");
push(@headerContent, " static void putByIndex(JSC::JSCell*, JSC::ExecState*, unsigned propertyName, JSC::JSValue);\n") if $dataNode->extendedAttributes->{"CustomIndexedSetter"};
push(@headerContent, " bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n") if $dataNode->extendedAttributes->{"DelegatingPutFunction"};
push(@headerContent, " bool putDelegate(JSC::ExecState*, const JSC::Identifier&, JSC::JSValue, JSC::PutPropertySlot&);\n") if $dataNode->extendedAttributes->{"CustomNamedSetter"};
}
if (!$hasParent) {
......@@ -1825,7 +1825,7 @@ sub GenerateImplementation
}
my $hasSetter = $hasReadWriteProperties
|| $dataNode->extendedAttributes->{"DelegatingPutFunction"}
|| $dataNode->extendedAttributes->{"CustomNamedSetter"}
|| $dataNode->extendedAttributes->{"CustomIndexedSetter"};
if ($hasSetter) {
......@@ -1842,7 +1842,7 @@ sub GenerateImplementation
push(@implContent, " return;\n");
push(@implContent, " }\n");
}
if ($dataNode->extendedAttributes->{"DelegatingPutFunction"}) {
if ($dataNode->extendedAttributes->{"CustomNamedSetter"}) {
push(@implContent, " if (thisObject->putDelegate(exec, propertyName, value, slot))\n");
push(@implContent, " return;\n");
}
......
......@@ -566,7 +566,7 @@ sub GenerateHeaderNamedAndIndexedPropertyAccessors
my $hasCustomIndexedGetter = $dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomIndexedSetter = $dataNode->extendedAttributes->{"CustomIndexedSetter"} && !$dataNode->extendedAttributes->{"HasNumericIndexGetter"};
my $hasCustomNamedGetter = $dataNode->extendedAttributes->{"NamedGetter"} || $dataNode->extendedAttributes->{"CustomNamedGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"DelegatingPutFunction"};
my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"CustomNamedSetter"};
my $hasCustomDeleters = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
my $hasCustomEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
if ($interfaceName eq "HTMLOptionsCollection") {
......@@ -2062,7 +2062,7 @@ sub GenerateImplementationIndexer
my $isSpecialCase = exists $indexerSpecialCases{$interfaceName};
if ($isSpecialCase) {
$hasGetter = 1;
if ($dataNode->extendedAttributes->{"DelegatingPutFunction"}) {
if ($dataNode->extendedAttributes->{"CustomNamedSetter"}) {
$hasCustomSetter = 1;
}
}
......@@ -2168,7 +2168,7 @@ END
return;
}
my $hasSetter = $dataNode->extendedAttributes->{"DelegatingPutFunction"};
my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"CustomNamedSetter"};
my $hasDeleter = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
my $hasEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
my $setOn = "Instance";
......@@ -2184,7 +2184,7 @@ END
}
push(@implContent, " desc->${setOn}Template()->SetNamedPropertyHandler(V8${interfaceName}::namedPropertyGetter, ");
push(@implContent, $hasSetter ? "V8${interfaceName}::namedPropertySetter, " : "0, ");
push(@implContent, $hasCustomNamedSetter ? "V8${interfaceName}::namedPropertySetter, " : "0, ");
# If there is a custom enumerator, there MUST be custom query to properly communicate property attributes.
push(@implContent, $hasEnumerator ? "V8${interfaceName}::namedPropertyQuery, " : "0, ");
push(@implContent, $hasDeleter ? "V8${interfaceName}::namedPropertyDeleter, " : "0, ");
......
......@@ -31,7 +31,7 @@
module test {
interface [
ActiveDOMObject,
DelegatingPutFunction,
CustomNamedSetter,
Conditional=Condition1|Condition2,
CallWith=ScriptExecutionContext,
Constructor(in DOMString str1, in [Optional=CallWithDefaultValue] DOMString str2),
......
......@@ -24,7 +24,7 @@ module css {
interface [
JSCustomMarkFunction,
JSGenerateIsReachable=ImplRoot,
DelegatingPutFunction,
CustomNamedSetter,
NamedGetter,
IndexedGetter,
CustomGetPropertyNames,
......
......@@ -30,7 +30,7 @@ module core {
NamedGetter,
CustomDeleteProperty,
CustomGetPropertyNames,
DelegatingPutFunction,
CustomNamedSetter,
] DOMStringMap {
};
......
......@@ -21,7 +21,7 @@
module html {
interface [
DelegatingPutFunction,
CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
CustomCall
] HTMLAppletElement : HTMLElement {
......
......@@ -21,7 +21,7 @@
module html {
interface [
DelegatingPutFunction,
CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
CustomCall
] HTMLEmbedElement : HTMLElement {
......
......@@ -21,7 +21,7 @@
module html {
interface [
DelegatingPutFunction,
CustomNamedSetter,
JSCustomGetOwnPropertySlotDelegate,
CustomCall
] HTMLObjectElement : HTMLElement {
......
......@@ -30,7 +30,7 @@ module window {
CheckDomainSecurity,
#endif
JSCustomGetOwnPropertySlotDelegate,
DelegatingPutFunction,
CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
......
......@@ -33,7 +33,7 @@ module window {
CheckDomainSecurity,
#endif
JSCustomGetOwnPropertySlotDelegate,
DelegatingPutFunction,
CustomNamedSetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
......
......@@ -30,7 +30,7 @@ module storage {
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
DelegatingPutFunction,
CustomNamedSetter,
] Storage {
readonly attribute [NotEnumerable] unsigned long length;
[NotEnumerable, ConvertNullStringTo=Null] DOMString key(in unsigned long index);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment