Commit 6fd7b362 authored by eric@webkit.org's avatar eric@webkit.org

2009-08-04 Eric Seidel <eric@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION (r45064): Drop caret remains in text control after the mouse exits
        https://bugs.webkit.org/show_bug.cgi?id=26787

        Fix some bogus comments noticed during testing.

        * fast/forms/drag-into-textarea.html:
        * fast/forms/drag-out-of-textarea.html:

2009-08-04  Eric Seidel  <eric@webkit.org>

        Reviewed by Simon Fraser.

        REGRESSION (r45064): Drop caret remains in text control after the mouse exits
        https://bugs.webkit.org/show_bug.cgi?id=26787

        Add back missing dragController()->clear() call.

        * manual-tests/drag-caret.html: Added.
        * page/DragController.cpp:
        (WebCore::DragController::tryDocumentDrag):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 92bdfec6
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION (r45064): Drop caret remains in text control after the mouse exits
https://bugs.webkit.org/show_bug.cgi?id=26787
Fix some bogus comments noticed during testing.
* fast/forms/drag-into-textarea.html:
* fast/forms/drag-out-of-textarea.html:
2009-08-04 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
......
......@@ -21,8 +21,7 @@ function runTest() {
eventSender.mouseMoveTo(x, y);
eventSender.mouseDown();
// Wait a moment so that the mouseDown will kick off a drag instead of a new selection.
// FIXME: Ugh, don't want delays in layout tests!
// Leap the event time so that mouseMove will start a new drag instead of changing selection.
eventSender.leapForward(400);
eventSender.mouseMoveTo(tx, ty);
eventSender.mouseUp();
......
......@@ -21,8 +21,7 @@ function runTest() {
eventSender.mouseMoveTo(tx, ty);
eventSender.mouseDown();
// Wait a moment so that the mouseDown will kick off a drag instead of a new selection.
// FIXME: Ugh, don't want delays in layout tests!
// Leap the event time so that mouseMove will start a new drag instead of changing selection.
eventSender.leapForward(400);
eventSender.mouseMoveTo(ix, iy);
eventSender.mouseUp();
......
2009-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Simon Fraser.
REGRESSION (r45064): Drop caret remains in text control after the mouse exits
https://bugs.webkit.org/show_bug.cgi?id=26787
Add back missing dragController()->clear() call.
* manual-tests/drag-caret.html: Added.
* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
2009-08-04 Chris Fleizach <cfleizach@apple.com>
Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
......
<p>This tests dragging over an input element, to make sure no drag-cursor is left behind.</p>
<p><input></p>
<p>Drag some text over the input element and make sure the Drag Caret disappears when the drag exits the input element. Per https://bugs.webkit.org/show_bug.cgi?id=26787</p>
......@@ -281,9 +281,7 @@ bool DragController::tryDocumentDrag(DragData* dragData, DragDestinationAction a
if (m_isHandlingDrag) {
m_page->dragCaretController()->clear();
return true;
}
if ((actionMask & DragDestinationActionEdit) && !m_isHandlingDrag && canProcessDrag(dragData)) {
} else if ((actionMask & DragDestinationActionEdit) && canProcessDrag(dragData)) {
if (dragData->containsColor()) {
operation = DragOperationGeneric;
return true;
......@@ -302,6 +300,8 @@ bool DragController::tryDocumentDrag(DragData* dragData, DragDestinationAction a
operation = dragIsMove(innerFrame->selection()) ? DragOperationMove : DragOperationCopy;
return true;
}
// If we're not over an editable region, make sure we're clearing any prior drag cursor.
m_page->dragCaretController()->clear();
return false;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment