Commit 6f3c90be authored by bdakin@apple.com's avatar bdakin@apple.com
Browse files

https://bugs.webkit.org/show_bug.cgi?id=96846

Tests failing on WK2 bots after giving fixed positioning its own 
stacking context

Reviewed by Geoffrey Garen.

Tests are failing because I checked in updated results that expect 
fixed positioning to create a stacking context. However, 
WebKitTestRunner does not enable ScrollingCoordinator, so the code 
that I added to enable stacking contexts for fixedPos is never 
actually running. This patch moves that code to a place where it will 
run for the testing tools, which matches the patch for WK1.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 5083f636
2012-09-14 Beth Dakin <bdakin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=96846
Tests failing on WK2 bots after giving fixed positioning its own
stacking context
Reviewed by Geoffrey Garen.
Tests are failing because I checked in updated results that expect
fixed positioning to create a stacking context. However,
WebKitTestRunner does not enable ScrollingCoordinator, so the code
that I added to enable stacking contexts for fixedPos is never
actually running. This patch moves that code to a place where it will
run for the testing tools, which matches the patch for WK1.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
2012-09-14 Julien Chaffraix <jchaffraix@webkit.org>
 
Revert r127457 and following fixes due to several hit-testing regressions
......
......@@ -261,9 +261,15 @@ void DrawingAreaImpl::setPaintingEnabled(bool paintingEnabled)
void DrawingAreaImpl::updatePreferences(const WebPreferencesStore& store)
{
#if PLATFORM(MAC)
// Soon we want pages with fixed positioned elements to be able to be scrolled by the ScrollingCoordinator.
// As a part of that work, we have to composite fixed position elements, and we have to allow those
// elements to create a stacking context.
m_webPage->corePage()->settings()->setAcceleratedCompositingForFixedPositionEnabled(true);
m_webPage->corePage()->settings()->setFixedPositionCreatesStackingContext(true);
// <rdar://problem/10697417>: It is necessary to force compositing when accelerate drawing
// is enabled on Mac so that scrollbars are always in their own layers.
#if PLATFORM(MAC)
if (m_webPage->corePage()->settings()->acceleratedDrawingEnabled())
m_webPage->corePage()->settings()->setForceCompositingMode(LayerTreeHost::supportsAcceleratedCompositing());
else
......
......@@ -76,12 +76,6 @@ TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea(WebPage* webPage, c
page->settings()->setScrollingCoordinatorEnabled(true);
page->settings()->setForceCompositingMode(true);
// Soon we want pages with fixed positioned elements to be able to be scrolled by the ScrollingCoordinator.
// As a part of that work, we have to composite fixed position elements, and we have to allow those
// elements to create a stacking context.
page->settings()->setAcceleratedCompositingForFixedPositionEnabled(true);
page->settings()->setFixedPositionCreatesStackingContext(true);
WebProcess::shared().eventDispatcher().addScrollingTreeForPage(webPage);
m_rootLayer = [CALayer layer];
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment