Commit 6d052a1e authored by haraken@chromium.org's avatar haraken@chromium.org

Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs

https://bugs.webkit.org/show_bug.cgi?id=77848

Reviewed by Adam Barth.

For naming consistency with [CustomGetter] and [CustomSetter],
this patch renames the following IDLs:

[HasIndexGetter] => [IndexedGetter]  (Remove "Has". This IDL is for "indexed" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
[HasCustomIndexSetter] => [CustomIndexedSetter]  (Ditto.)
[HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):

* bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
* bindings/scripts/test/TestTypedArray.idl: Ditto.

* Modules/gamepad/GamepadList.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSTransformValue.idl:
* dom/ClientRectList.idl:
* dom/DOMStringList.idl:
* dom/DOMStringMap.idl:
* dom/DataTransferItemList.idl:
* dom/NamedNodeMap.idl:
* dom/NodeList.idl:
* dom/TouchList.idl:
* fileapi/EntryArray.idl:
* fileapi/EntryArraySync.idl:
* fileapi/FileList.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLFormElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLPropertiesCollection.idl:
* html/HTMLSelectElement.idl:
* html/TextTrackCueList.idl:
* html/canvas/CanvasPixelArray.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/track/TextTrackList.idl:
* mediastream/MediaStreamList.idl:
* mediastream/MediaStreamTrackList.idl:
* page/SpeechInputResultList.idl:
* page/WebKitAnimationList.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/Storage.idl:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 6e77be08
2012-02-06 Kentaro Hara <haraken@chromium.org>
Rename [HasIndexGetter], [HasNameGetter] and [HasCustomIndexSetter] IDLs
https://bugs.webkit.org/show_bug.cgi?id=77848
Reviewed by Adam Barth.
For naming consistency with [CustomGetter] and [CustomSetter],
this patch renames the following IDLs:
[HasIndexGetter] => [IndexedGetter] (Remove "Has". This IDL is for "indexed" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-indexed-properties)
[HasCustomIndexSetter] => [CustomIndexedSetter] (Ditto.)
[HasNameGetter] => [NamedGetter] (Remove "Has". This IDL is for "named" properties
in the Web IDL: http://dev.w3.org/2006/webapi/WebIDL/#idl-named-properties)
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateGetOwnPropertyDescriptorBody):
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeaderNamedAndIndexedPropertyAccessors):
(GenerateImplementationIndexer):
(GenerateImplementationNamedPropertyGetter):
* bindings/scripts/test/TestEventTarget.idl: No change in run-bindings-tests results.
* bindings/scripts/test/TestTypedArray.idl: Ditto.
* Modules/gamepad/GamepadList.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSValueList.idl:
* css/MediaList.idl:
* css/StyleSheetList.idl:
* css/WebKitCSSFilterValue.idl:
* css/WebKitCSSKeyframesRule.idl:
* css/WebKitCSSTransformValue.idl:
* dom/ClientRectList.idl:
* dom/DOMStringList.idl:
* dom/DOMStringMap.idl:
* dom/DataTransferItemList.idl:
* dom/NamedNodeMap.idl:
* dom/NodeList.idl:
* dom/TouchList.idl:
* fileapi/EntryArray.idl:
* fileapi/EntryArraySync.idl:
* fileapi/FileList.idl:
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLCollection.idl:
* html/HTMLFormElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLPropertiesCollection.idl:
* html/HTMLSelectElement.idl:
* html/TextTrackCueList.idl:
* html/canvas/CanvasPixelArray.idl:
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
* html/track/TextTrackList.idl:
* mediastream/MediaStreamList.idl:
* mediastream/MediaStreamTrackList.idl:
* page/SpeechInputResultList.idl:
* page/WebKitAnimationList.idl:
* plugins/DOMMimeTypeArray.idl:
* plugins/DOMPlugin.idl:
* plugins/DOMPluginArray.idl:
* storage/Storage.idl:
2012-02-06 Allan Sandfeld Jensen <allan.jensen@nokia.com>
Ensure timers and other active DOM objects do not fire in suspended documents.
......@@ -27,7 +27,7 @@ module dom {
interface [
Conditional=GAMEPAD,
HasIndexGetter
IndexedGetter
] GamepadList {
readonly attribute unsigned long length;
Gamepad item(in [Optional=CallWithDefaultValue] unsigned long index);
......
......@@ -563,9 +563,9 @@ sub GenerateHeaderNamedAndIndexedPropertyAccessors
{
my $dataNode = shift;
my $interfaceName = $dataNode->name;
my $hasCustomIndexedGetter = $dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomIndexedSetter = $dataNode->extendedAttributes->{"HasCustomIndexSetter"} && !$dataNode->extendedAttributes->{"HasNumericIndexGetter"};
my $hasCustomNamedGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $dataNode->extendedAttributes->{"HasOverridingNameGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomIndexedGetter = $dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomIndexedSetter = $dataNode->extendedAttributes->{"CustomIndexedSetter"} && !$dataNode->extendedAttributes->{"HasNumericIndexGetter"};
my $hasCustomNamedGetter = $dataNode->extendedAttributes->{"NamedGetter"} || $dataNode->extendedAttributes->{"HasOverridingNameGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomNamedSetter = $dataNode->extendedAttributes->{"DelegatingPutFunction"};
my $hasCustomDeleters = $dataNode->extendedAttributes->{"CustomDeleteProperty"};
my $hasCustomEnumerator = $dataNode->extendedAttributes->{"CustomGetPropertyNames"};
......@@ -2040,8 +2040,8 @@ sub GenerateImplementationIndexer
my $interfaceName = $dataNode->name;
# FIXME: Figure out what HasNumericIndexGetter is really supposed to do. Right now, it's only set on WebGL-related files.
my $hasCustomSetter = $dataNode->extendedAttributes->{"HasCustomIndexSetter"} && !$dataNode->extendedAttributes->{"HasNumericIndexGetter"};
my $hasGetter = $dataNode->extendedAttributes->{"HasIndexGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
my $hasCustomSetter = $dataNode->extendedAttributes->{"CustomIndexedSetter"} && !$dataNode->extendedAttributes->{"HasNumericIndexGetter"};
my $hasGetter = $dataNode->extendedAttributes->{"IndexedGetter"} || $dataNode->extendedAttributes->{"CustomGetOwnPropertySlot"};
# FIXME: Find a way to not have to special-case HTMLOptionsCollection.
if ($interfaceName eq "HTMLOptionsCollection") {
......@@ -2142,7 +2142,7 @@ sub GenerateImplementationNamedPropertyGetter
$hasCustomGetter = 0;
}
my $hasGetter = $dataNode->extendedAttributes->{"HasNameGetter"} || $hasCustomGetter;
my $hasGetter = $dataNode->extendedAttributes->{"NamedGetter"} || $hasCustomGetter;
if (!$hasGetter) {
return;
}
......
......@@ -30,8 +30,8 @@ module events {
interface [
EventTarget,
HasIndexGetter,
HasNameGetter,
IndexedGetter,
NamedGetter,
MasqueradesAsUndefined
] TestEventTarget {
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module css {
// Introduced in DOM Level 2:
interface [
JSCustomIsReachable,
HasIndexGetter,
IndexedGetter,
V8DependentLifetime
] CSSRuleList {
readonly attribute unsigned long length;
......
......@@ -25,8 +25,8 @@ module css {
JSCustomMarkFunction,
JSGenerateIsReachable=ImplRoot,
DelegatingPutFunction,
HasNameGetter,
HasIndexGetter,
NamedGetter,
IndexedGetter,
CustomGetPropertyNames,
V8DependentLifetime
] CSSStyleDeclaration {
......
......@@ -27,7 +27,7 @@ module css {
// Introduced in DOM Level 2:
interface [
HasIndexGetter
IndexedGetter
] CSSValueList : CSSValue {
readonly attribute unsigned long length;
CSSValue item(in [Optional=CallWithDefaultValue] unsigned long index);
......
......@@ -28,7 +28,7 @@ module stylesheets {
// Introduced in DOM Level 2:
interface [
JSGenerateIsReachable,
HasIndexGetter
IndexedGetter
] MediaList {
attribute [TreatNullAs=NullString, ConvertNullStringTo=Null] DOMString mediaText
......
......@@ -23,8 +23,8 @@ module stylesheets {
// Introduced in DOM Level 2:
interface [
JSGenerateIsReachable=ImplDocument,
HasIndexGetter,
HasNameGetter,
IndexedGetter,
NamedGetter,
V8DependentLifetime
] StyleSheetList {
readonly attribute unsigned long length;
......
......@@ -27,7 +27,7 @@ module css {
interface [
Conditional=CSS_FILTERS,
HasIndexGetter,
IndexedGetter,
DontCheckEnums
] WebKitCSSFilterValue : CSSValueList {
......
......@@ -30,7 +30,7 @@ module css {
// Introduced in DOM Level ?:
interface [
HasIndexGetter
IndexedGetter
] WebKitCSSKeyframesRule : CSSRule {
attribute [ConvertNullStringTo=Null, TreatNullAs=NullString] DOMString name;
......
......@@ -29,7 +29,7 @@
module css {
interface [
HasIndexGetter,
IndexedGetter,
DontCheckEnums
] WebKitCSSTransformValue : CSSValueList {
......
......@@ -27,7 +27,7 @@
module view {
interface [
HasIndexGetter
IndexedGetter
] ClientRectList {
readonly attribute unsigned long length;
ClientRect item(in [IsIndex,Optional=CallWithDefaultValue] unsigned long index);
......
......@@ -26,7 +26,7 @@
module core {
interface [
HasIndexGetter
IndexedGetter
] DOMStringList {
readonly attribute unsigned long length;
[ConvertNullStringTo=Null] DOMString item(in [IsIndex,Optional=CallWithDefaultValue] unsigned long index);
......
......@@ -27,7 +27,7 @@ module core {
interface [
JSGenerateIsReachable=ImplElementRoot,
HasNameGetter,
NamedGetter,
CustomDeleteProperty,
CustomGetPropertyNames,
DelegatingPutFunction,
......
......@@ -32,7 +32,7 @@ module core {
interface [
Conditional=DATA_TRANSFER_ITEMS,
HasIndexGetter,
IndexedGetter,
GenerateNativeConverter,
#if defined(V8_BINDING) && V8_BINDING
CustomDeleteProperty,
......
......@@ -23,8 +23,8 @@ module core {
interface [
JSGenerateIsReachable=ImplElementRoot,
JSCustomMarkFunction,
HasIndexGetter,
HasNameGetter
IndexedGetter,
NamedGetter
] NamedNodeMap {
Node getNamedItem(in [Optional=CallWithDefaultValue] DOMString name);
......
......@@ -22,8 +22,8 @@ module core {
interface [
JSCustomIsReachable,
HasIndexGetter,
HasNameGetter
IndexedGetter,
NamedGetter
] NodeList {
Node item(in [IsIndex,Optional=CallWithDefaultValue] unsigned long index);
......
......@@ -27,7 +27,7 @@ module events {
interface [
Conditional=TOUCH_EVENTS,
HasIndexGetter
IndexedGetter
] TouchList {
readonly attribute unsigned long length;
......
......@@ -31,7 +31,7 @@
module storage {
interface [
Conditional=FILE_SYSTEM,
HasIndexGetter,
IndexedGetter,
JSNoStaticTables
] EntryArray {
readonly attribute unsigned long length;
......
......@@ -31,7 +31,7 @@
module storage {
interface [
Conditional=FILE_SYSTEM,
HasIndexGetter,
IndexedGetter,
JSNoStaticTables
] EntryArraySync {
readonly attribute unsigned long length;
......
......@@ -26,7 +26,7 @@
module html {
interface [
HasIndexGetter,
IndexedGetter,
JSNoStaticTables
] FileList {
readonly attribute unsigned long length;
......
......@@ -25,7 +25,7 @@
module core {
interface [
HasIndexGetter,
IndexedGetter,
JSGenerateToJS
] DOMSettableTokenList : DOMTokenList {
attribute DOMString value;
......
......@@ -26,7 +26,7 @@ module core {
interface [
JSGenerateIsReachable=ImplElementRoot,
HasIndexGetter
IndexedGetter
] DOMTokenList {
readonly attribute unsigned long length;
[ConvertNullStringTo=Null] DOMString item(in unsigned long index);
......
......@@ -26,8 +26,8 @@
module html {
interface [
HasIndexGetter,
HasNameGetter,
IndexedGetter,
NamedGetter,
CustomCall,
MasqueradesAsUndefined,
JSGenerateIsReachable
......
......@@ -21,8 +21,8 @@
module html {
interface [
HasIndexGetter,
HasNameGetter,
IndexedGetter,
NamedGetter,
JSCustomToJS,
JSGenerateIsReachable,
ObjCPolymorphic
......
......@@ -21,7 +21,7 @@
module html {
interface [
HasIndexGetter,
IndexedGetter,
HasOverridingNameGetter
] HTMLFormElement : HTMLElement {
readonly attribute HTMLCollection elements;
......
......@@ -22,7 +22,7 @@ module html {
interface [
GenerateNativeConverter,
HasCustomIndexSetter
CustomIndexedSetter
] HTMLOptionsCollection : HTMLCollection {
attribute long selectedIndex;
attribute [Custom] unsigned long length
......
......@@ -32,7 +32,7 @@ module html {
interface [
Conditional=MICRODATA,
HasIndexGetter
IndexedGetter
] HTMLPropertiesCollection : HTMLCollection {
readonly attribute unsigned long length;
Node item(in unsigned long index);
......
......@@ -21,8 +21,8 @@
module html {
interface [
HasIndexGetter,
HasCustomIndexSetter
IndexedGetter,
CustomIndexedSetter
] HTMLSelectElement : HTMLElement {
readonly attribute DOMString type;
attribute long selectedIndex;
......
......@@ -28,7 +28,7 @@ module html {
interface [
Conditional=VIDEO_TRACK,
V8EnabledAtRuntime=webkitVideoTrack,
HasIndexGetter
IndexedGetter
] TextTrackCueList {
readonly attribute unsigned long length;
TextTrackCue item(in unsigned long index);
......
......@@ -32,7 +32,7 @@ module html {
OmitConstructor,
CustomHeader,
HasNumericIndexGetter,
HasCustomIndexSetter
CustomIndexedSetter
] CanvasPixelArray {
#if !defined(V8_BINDING) || !V8_BINDING
readonly attribute long length;
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -27,7 +27,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module html {
interface [
CustomConstructor,
HasNumericIndexGetter,
HasCustomIndexSetter,
CustomIndexedSetter,
GenerateNativeConverter,
JSNoStaticTables,
JSCustomToJS,
......
......@@ -28,7 +28,7 @@ module html {
interface [
Conditional=VIDEO_TRACK,
V8EnabledAtRuntime=webkitVideoTrack,
HasIndexGetter,
IndexedGetter,
EventTarget,
JSCustomMarkFunction,
JSCustomIsReachable
......
......@@ -26,7 +26,7 @@ module core {
interface [
Conditional=MEDIA_STREAM,
HasIndexGetter
IndexedGetter
] MediaStreamList {
MediaStream item(in [IsIndex] unsigned long index);
......
......@@ -26,7 +26,7 @@ module core {
interface [
Conditional=MEDIA_STREAM,
HasIndexGetter
IndexedGetter
] MediaStreamTrackList {
MediaStreamTrack item(in [IsIndex] unsigned long index);
......
......@@ -26,7 +26,7 @@
module core {
interface [
HasIndexGetter,
IndexedGetter,
Conditional=INPUT_SPEECH
] SpeechInputResultList {
readonly attribute unsigned long length;
......
......@@ -26,7 +26,7 @@
module html {
interface [
HasIndexGetter
IndexedGetter
] WebKitAnimationList {
readonly attribute unsigned long length;
WebKitAnimation item(in unsigned long index);
......
......@@ -22,8 +22,8 @@ module window {
interface [
JSGenerateIsReachable=ImplFrame,
HasNameGetter,
HasIndexGetter
NamedGetter,
IndexedGetter
] DOMMimeTypeArray {
readonly attribute unsigned long length;
DOMMimeType item(in [Optional=CallWithDefaultValue] unsigned long index);
......
......@@ -21,8 +21,8 @@
module window {
interface [
HasNameGetter,
HasIndexGetter
NamedGetter,
IndexedGetter
] DOMPlugin {
readonly attribute DOMString name;
readonly attribute DOMString filename;
......
......@@ -22,8 +22,8 @@ module window {
interface [
JSGenerateIsReachable=ImplFrame,
HasNameGetter,
HasIndexGetter
NamedGetter,
IndexedGetter
] DOMPluginArray {
readonly attribute unsigned long length;
DOMPlugin item(in [Optional=CallWithDefaultValue] unsigned long index);
......
......@@ -26,7 +26,7 @@
module storage {
interface [
HasNameGetter,
NamedGetter,
JSGenerateIsReachable=ImplFrame,
CustomDeleteProperty,
CustomGetPropertyNames,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment