Commit 6bf2c584 authored by ap's avatar ap

Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=13105
        REGRESSION: an exception raised when calculating base value of a dot expression is not returned

        Test: fast/js/dot-node-base-exception.html

        * kjs/nodes.cpp:
        (FunctionCallDotNode::evaluate): Added the necessary KJS_CHECKEXCEPTIONVALUE.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 99c665bf
2007-03-18 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=13105
REGRESSION: an exception raised when calculating base value of a dot expression is not returned
Test: fast/js/dot-node-base-exception.html
* kjs/nodes.cpp:
(FunctionCallDotNode::evaluate): Added the necessary KJS_CHECKEXCEPTIONVALUE.
2007-03-18 Steve Falkenburg <sfalken@apple.com>
Build fix.
......
......@@ -755,6 +755,7 @@ static const char *dotExprDoesNotAllowCallsString()
JSValue *FunctionCallDotNode::evaluate(ExecState *exec)
{
JSValue *baseVal = base->evaluate(exec);
KJS_CHECKEXCEPTIONVALUE
JSObject *baseObj = baseVal->toObject(exec);
PropertySlot slot;
......
2007-03-18 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=13105
REGRESSION: an exception raised when calculating base value of a dot expression is not returned
* fast/js/dot-node-base-exception-expected.txt: Added.
* fast/js/dot-node-base-exception.html: Added.
* fast/js/resources/dot-node-base-exception.js: Added.
2007-03-17 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Sam Weinig.
This test checks that a correct exception is raised when calculating the base value of a dot expression fails.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS (document.appendChild()).foobar() threw exception Error: NOT_FOUND_ERR: DOM Exception 8.
PASS successfullyParsed is true
TEST COMPLETE
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
<html>
<head>
<link rel="stylesheet" href="resources/js-test-style.css">
<script src="resources/js-test-pre.js"></script>
</head>
<body>
<p id="description"></p>
<div id="console"></div>
<script src="resources/dot-node-base-exception.js"></script>
<script src="resources/js-test-post.js"></script>
</body>
</html>
description(
"This test checks that a correct exception is raised when calculating the base value of a dot expression fails."
);
// Should be a DOM exception, not just some "TypeError: Null value".
shouldThrow('(document.appendChild()).foobar()', '"Error: NOT_FOUND_ERR: DOM Exception 8"');
var successfullyParsed = true;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment