Commit 692e06e4 authored by ap's avatar ap
Browse files

2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com>

        Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
        REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading

        No test case added (probably requires new DumpRenderTree functionality)

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged): Added early return if the document is
        being destroyed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
parent 932806a9
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
   
Reviewed by Hyatt. Reviewed by Hyatt.
Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842 Test for http://bugs.webkit.org/show_bug.cgi?id=10842
REGRESSION (r15418): contenteditable div truncates rightmost Japanese character REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
   
* fast/text/line-breaks-after-white-space-expected.checksum: Added. * fast/text/line-breaks-after-white-space-expected.checksum: Added.
2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com>
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
No test case added (probably requires new DumpRenderTree functionality)
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged): Added early return if the document is
being destroyed.
2006-10-01 Graham Dennis <graham.dennis@gmail.com> 2006-10-01 Graham Dennis <graham.dennis@gmail.com>
   
Reviewed by Hyatt. Reviewed by Hyatt.
   
Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842 Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
REGRESSION (r15418): contenteditable div truncates rightmost Japanese character REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
Make sure we only break after a space (and not any other valid line-break) if Make sure we only break after a space (and not any other valid line-break) if
...@@ -96,6 +96,9 @@ void RenderImage::setCachedImage(CachedImage* newImage) ...@@ -96,6 +96,9 @@ void RenderImage::setCachedImage(CachedImage* newImage)
void RenderImage::imageChanged(CachedImage* o) void RenderImage::imageChanged(CachedImage* o)
{ {
if (documentBeingDestroyed())
return;
if (o != m_cachedImage) { if (o != m_cachedImage) {
RenderReplaced::imageChanged(o); RenderReplaced::imageChanged(o);
return; return;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment